-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(assertions): added getResourceId method to Template #33521
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
2812d88
to
743a110
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Exemption Request Only changes in assertions module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thank you!
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: The pull request can't be updated You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
Reason for this change
Sometimes you want to correlate how cloudformation resources correlate to each other.
CDK synthesizes the template expectedly with
Ref
andFn:GetAtt
.Currently you'll have to do something like this to verify that a bucketpolicy is attached to the correct bucket:
Description of changes
Added method
getResourceId
onTemplate
to retrieve a distinct match's resource id.Description of how you validated changes
Unit tests. Integration tests not applicable.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license