Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spec): current cfnspec contains breaking changes we are not ready to merge yet #33481

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Feb 17, 2025

Restting to the versions used in 2.178.2 (see comment below).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Feb 17, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 17, 2025 16:02
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 17, 2025
Comment on lines +45 to +47
"@aws-cdk/aws-service-spec": "0.1.51",
"@aws-cdk/service-spec-importers": "0.0.64",
"@aws-cdk/service-spec-types": "0.0.117"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to guarantee the expected version and that there are no install time surprises. We remove this when we are ready to accept a new spec.

@iliapolo iliapolo changed the title fix(spec): reset service spec to the one we used in latest release (2.187.2) fix(spec): current cfnspec contains breaking changes we are not ready to merge yet Feb 17, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@iliapolo iliapolo changed the title fix(spec): current cfnspec contains breaking changes we are not ready to merge yet chore(spec): current cfnspec contains breaking changes we are not ready to merge yet Feb 17, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 17, 2025 16:05

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@iliapolo
Copy link
Contributor Author

See tag 2.178.2:

"@aws-cdk/aws-service-spec": "^0.1.51",
"@aws-cdk/service-spec-importers": "^0.0.64",
"@aws-cdk/service-spec-types": "^0.0.117",

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.00%. Comparing base (11a75b2) to head (0e3157f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33481   +/-   ##
=======================================
  Coverage   81.00%   81.00%           
=======================================
  Files         238      238           
  Lines       14271    14271           
  Branches     2492     2492           
=======================================
  Hits        11560    11560           
  Misses       2425     2425           
  Partials      286      286           
Flag Coverage Δ
suite.unit 81.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.92% <ø> (ø)
packages/aws-cdk-lib/core 82.16% <ø> (ø)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the latest spec version of this specific resource because this PR already depends on it, as it makes use of the new containerFormat property.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0e3157f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Feb 17, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 50b9b6f into main Feb 17, 2025
21 checks passed
@mergify mergify bot deleted the epolon/reset-service-spec branch February 17, 2025 17:11
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants