chore(toolkit): capture all output from an app #33259
Conversation
packages/@aws-cdk/toolkit/lib/api/cloud-assembly/private/source-builder.ts
Show resolved
Hide resolved
| // Default codes -- all 0000 codes | ||
| CDK_TOOLKIT_I0000: 'Default toolkit info code', | ||
| CDK_TOOLKIT_E0000: 'Default toolkit error code', | ||
| CDK_TOOLKIT_W0000: 'Default toolkit warning code', | ||
| CDK_SDK_I0000: 'Default sdk info code', | ||
| CDK_SDK_E0000: 'Default sdk error code', | ||
| CDK_SDK_WOOOO: 'Default sdk warning code', | ||
| CDK_ASSETS_I0000: 'Default assets info code', | ||
| CDK_ASSETS_E0000: 'Default assets error code', | ||
| CDK_ASSETS_W0000: 'Default assets warning code', | ||
| CDK_ASSEMBLY_I0000: 'Default assembly info code', | ||
| CDK_ASSEMBLY_E0000: 'Default assembly error code', | ||
| CDK_ASSEMBLY_W0000: 'Default assembly warning code', |
There was a problem hiding this comment.
I don't want to allow explicitly using this code for now. When generating the docs page we can probably inject the description differently.
There was a problem hiding this comment.
I thought this would break the place where we generate 0000 codes
There was a problem hiding this comment.
It does not apparently!
| return { | ||
| ioHost: this.ioHost, | ||
| ioHost: withAction(this.ioHost, 'assembly'), |
There was a problem hiding this comment.
Messages previously came through without an action.
There was a problem hiding this comment.
No app should do that, but you never know...
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33259 +/- ##
=======================================
Coverage 80.84% 80.84%
=======================================
Files 232 232
Lines 14135 14135
Branches 2460 2460
=======================================
Hits 11428 11428
Misses 2427 2427
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks:
You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
|
force-merging since codecov build is broken |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue #32997
Relates to #32997
Reason for this change
When a CDK app is invoked by a sub-shell, we need to capture all output by lines and send it to the IoHost.
Description of changes
Adds an
EventPublisherinterface to theexecInChildProcesshelper. This is getting passed in a publisher that uses the IoHost.Inspired from the ShellEventPublisher in cdk-assets.
Describe any new or updated permissions being added
n/a
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license