-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): set (default) stack termination protection on (parent) stage level #33239
Open
aripalo
wants to merge
12
commits into
aws:main
Choose a base branch
from
aripalo:feat/termination-protection-via-stage-prop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(core): set (default) stack termination protection on (parent) stage level #33239
aripalo
wants to merge
12
commits into
aws:main
from
aripalo:feat/termination-protection-via-stage-prop
+503
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p2
labels
Jan 30, 2025
github-actions
bot
added
the
beginning-contributor
[Pilot] contributed between 0-2 PRs to the CDK
label
Jan 30, 2025
aws-cdk-automation
previously requested changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
aws-cdk-automation
dismissed
their stale review
January 30, 2025 18:08
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
2 tasks
aws-cdk-automation
added
the
pr/needs-community-review
This PR needs a review from a Trusted Community Member or Core Team Member.
label
Jan 30, 2025
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beginning-contributor
[Pilot] contributed between 0-2 PRs to the CDK
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p2
pr/needs-community-review
This PR needs a review from a Trusted Community Member or Core Team Member.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #31449.
This is a new pull request, since the previous one did not receive any activity/communication and had some CI quality gate check issues, so trying again if this time there's a change for getting this merged!
Reason for this change
New feature: Enable setting Stack (default) termination protection on (parent)
Stage
level.Description of changes
Changes to
cdk.Stage
:terminationProtection
intoStageProps
terminationProtection
property from parent stage, but also it can be overriden by child StagesChanges to
cdk.Stack
:terminationProtection
from parent Stage – unless overriden on Stack levelterminationProtection
is not set in the Stack level or in any of its parent Stages, the value will default tofalse
as before – hence this is NOT a breaking change.Describe any new or updated permissions being added
None.
Description of how you validated changes
I've originally done a PoC in my own codebase (by extending
cdk.Stage
).After modifications into aws-cdk codebase:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license