Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert ensure docker file runs as non root user #33004

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Jan 18, 2025

Reverts #32976

After discussing with team, I'm going to revert the original PR.

This is because we notice that CDK when bundling supports the following feature: https://docs.aws.amazon.com/cdk/api/v2/python/aws_cdk.aws_lambda_nodejs/ICommandHooks.html

beforeBundling: Commands in this hook run before the bundling process begins, outside the Docker container. These are executed on the local machine.
beforeInstall: Commands in this hook run inside the Docker container before npm install or npm ci commands are executed.
afterBundling: Commands in this hook run inside the Docker container after the bundling process completes.

This means that users can provide custom commands to run inside the docker container and we do not know what current users run. They could provide a command that require root access and this will be a regression once released.

@github-actions github-actions bot added the p2 label Jan 18, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 18, 2025 00:06
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 18, 2025
@mrgrain
Copy link
Contributor

mrgrain commented Jan 18, 2025

@GavinZZ Best to add a note why it was reverted.

@GavinZZ
Copy link
Contributor Author

GavinZZ commented Jan 18, 2025

@mrgrain thanks for the reminder, I added reasoning to the revert.

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.39%. Comparing base (d8cd4bd) to head (a7efcd6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33004   +/-   ##
=======================================
  Coverage   81.39%   81.39%           
=======================================
  Files         225      225           
  Lines       13714    13714           
  Branches     2411     2411           
=======================================
  Hits        11162    11162           
  Misses       2277     2277           
  Partials      275      275           
Flag Coverage Δ
suite.unit 81.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.70% <ø> (ø)
packages/aws-cdk-lib/core 82.10% <ø> (ø)

Copy link
Contributor

mergify bot commented Jan 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a7efcd6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 28067b0 into main Jan 18, 2025
19 checks passed
Copy link
Contributor

mergify bot commented Jan 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the revert-32976-yuanhaoz/docker-user branch January 18, 2025 01:05
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants