chore: fix memory overflow for buffered console #32986
Conversation
Since the buffered console captures stdout/stderr, in some call sequences it keeps recursing forever and overflows memory. It does not repro in this repository, but it repros in a different one. The fix is to stop capturing while we print results.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32986 +/- ##
==========================================
- Coverage 81.48% 81.44% -0.04%
==========================================
Files 226 225 -1
Lines 13768 13702 -66
Branches 2416 2404 -12
==========================================
- Hits 11219 11160 -59
+ Misses 2271 2267 -4
+ Partials 278 275 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/32986/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Since the buffered console captures stdout/stderr, in some call sequences it keeps recursing forever and overflows memory.
It does not repro in this repository, but it repros in a different one.
The fix is to stop capturing while we print results.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license