Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(toolkit): requireApproval option for deploy #32977

Merged
merged 11 commits into from
Jan 17, 2025

Merge branch 'main' into conroy/deploy-tests

40ea16b
Select commit
Loading
Failed to load commit list.
Merged

chore(toolkit): requireApproval option for deploy #32977

Merge branch 'main' into conroy/deploy-tests
40ea16b
Select commit
Loading
Failed to load commit list.
Mergify / Queue: Embarked in merge queue succeeded Jan 17, 2025 in 0s

The pull request embarked with main (ebe9580) will be merged soon

Required conditions for merge:

  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #approved-reviews-by>=1
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0
  • -approved-reviews-by~=author
  • -closed
  • -label~=(blocked|do-not-merge|no-squash)
  • -merged
  • -title~=(WIP|wip)
  • base!=release
  • status-success=validate-pr
  • status-success~=AWS CodeBuild us-east-1
  • any of [🛡 GitHub branch protection]:
    • check-success = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
    • check-neutral = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
    • check-skipped = AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv)
  • any of [🛡 GitHub branch protection]:
    • check-success = validate-pr
    • check-neutral = validate-pr
    • check-skipped = validate-pr
  • any of [🛡 GitHub branch protection]:
    • check-success = codecov/patch/packages/aws-cdk
    • check-neutral = codecov/patch/packages/aws-cdk
    • check-skipped = codecov/patch/packages/aws-cdk
  • any of [🛡 GitHub branch protection]:
    • check-success = codecov/project/packages/aws-cdk
    • check-neutral = codecov/project/packages/aws-cdk
    • check-skipped = codecov/project/packages/aws-cdk
  • any of [🛡 GitHub branch protection]:
    • check-success = codecov/patch/packages/aws-cdk-lib/core
    • check-neutral = codecov/patch/packages/aws-cdk-lib/core
    • check-skipped = codecov/patch/packages/aws-cdk-lib/core
  • any of [🛡 GitHub branch protection]:
    • check-success = codecov/project/packages/aws-cdk-lib/core
    • check-neutral = codecov/project/packages/aws-cdk-lib/core
    • check-skipped = codecov/project/packages/aws-cdk-lib/core

Check-runs and statuses of the embarked pull request #32977:

auto-approve details
submit-to-test-pipeline details
AWS CodeBuild us-east-1 (AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv) Build succeeded for project AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQvdetails
Analyze (javascript-typescript) details
Analyze (python) details
CodeQL — No new alerts in code changed by this pull requestdetails
cli-changes details
codecov/patch — Coverage not affected when comparing ebe9580...40ea16bdetails
codecov/patch/packages/aws-cdk — Coverage not affected when comparing ebe9580...40ea16bdetails
codecov/patch/packages/aws-cdk-lib/core — Coverage not affected when comparing ebe9580...40ea16bdetails
codecov/project — 81.44% (+0.00%) compared to ebe9580details
codecov/project/packages/aws-cdk — 80.81% (+0.00%) compared to ebe9580details
codecov/project/packages/aws-cdk-lib/core — 82.10% (+0.00%) compared to ebe9580details
collect details
download-if-workflow-run details
validate-pr details