chore(cli): also suppress test logging for CLI #32952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CLI tests are also quite noisy. Suppress logging for those as well by using the `jest-bufferedconsole` environment. Enhance the buffered-console environments by also capturing writes to `process.stdout` and `process.stderr`. Yes, the files are copy/pasted between the CLI and the library. I don't see an easy way around this, and the code is going to be lifted into a separate repo soon anyway.
mrgrain
approved these changes
Jan 15, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32952 +/- ##
=======================================
Coverage 81.40% 81.40%
=======================================
Files 223 223
Lines 13727 13727
Branches 2411 2411
=======================================
Hits 11175 11175
Misses 2274 2274
Partials 278 278
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI tests are also quite noisy. Suppress logging for those as well by using the
jest-bufferedconsoleenvironment.Enhance the buffered-console environments by also capturing writes to
process.stdoutandprocess.stderr.Yes, the files are copy/pasted between the CLI and the library. I don't see an easy way around this, and the code is going to be lifted into a separate repo soon anyway.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license