Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix property test for aspects #32639

Merged
merged 2 commits into from
Dec 23, 2024
Merged

chore: fix property test for aspects #32639

merged 2 commits into from
Dec 23, 2024

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Dec 23, 2024

The test was asserting that aspects with lower priority would be executed before aspects with higher priority; but this disregarded their application time. If an aspect with lower priority is added before the execution of an aspect happens, there is no way it can execute before it.

This fixes error assertions that look like this:

    TREE
      +- (root)  <-- AddAspect_2822([First,], Mutate_2743@0)@0, Mutate_2743@0 (added), Mutate_2751@0 (added)
           +- First  <-- AddAspect_2822([First,], Mutate_2743@0)@0, AddAspect_2809([], Mutate_2751@0)@0, Mutate_2743@0 (added)
           +- (added) Tree
    VISITS
      0. <root> <-- AddAspect_2822([First,], Mutate_2743@0)
      1. First <-- AddAspect_2822([First,], Mutate_2743@0)
      2. First <-- AddAspect_2809([], Mutate_2751@0)
      3. First <-- Mutate_2743
      4. Tree <-- AddAspect_2822([First,], Mutate_2743@0)

    Got error: Aspect Mutate_2743@0 at 3 should have been before AddAspect_2809([], Mutate_2751@0)@0 at 2, but was after


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The test was asserting that aspects with lower priority would be
executed before aspects with higher priority; but this disregarded their
application time. If an aspect with lower priority is added before
the execution of an aspect happens, there is no way it can execute
before it.
@rix0rrr rix0rrr requested a review from a team as a code owner December 23, 2024 09:04
@github-actions github-actions bot added the p2 label Dec 23, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 23, 2024 09:04
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.54%. Comparing base (8718767) to head (d0d7222).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32639   +/-   ##
=======================================
  Coverage   80.54%   80.54%           
=======================================
  Files         106      106           
  Lines        6954     6954           
  Branches     1287     1287           
=======================================
  Hits         5601     5601           
  Misses       1175     1175           
  Partials      178      178           
Flag Coverage Δ
suite.unit 80.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.54% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 23, 2024
Copy link
Contributor

mergify bot commented Dec 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@sumupitchayan sumupitchayan added the pr/do-not-merge This PR should not be merged at this time. label Dec 23, 2024
Copy link
Contributor

mergify bot commented Dec 23, 2024

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #32639 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:

  • -label~=(blocked|do-not-merge|no-squash|two-approvers)
  • status-success=validate-pr
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default-squash]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = validate-pr
        • check-skipped = validate-pr
        • check-success = validate-pr

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 23, 2024
@sumupitchayan sumupitchayan removed the pr/do-not-merge This PR should not be merged at this time. label Dec 23, 2024
Copy link
Contributor

mergify bot commented Dec 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d0d7222
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Dec 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0150854 into main Dec 23, 2024
17 checks passed
@mergify mergify bot deleted the huijbers/aspect-prop-test branch December 23, 2024 20:36
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants