Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert "chore(release): 2.174.0 (#32591)" #32611

Closed
wants to merge 1 commit into from

Conversation

HBobertz
Copy link
Contributor

@HBobertz HBobertz commented Dec 20, 2024

This reverts commit faa1db0, reversing changes made to f8e6207.

Issue # (if applicable)

Reason for this change

The 2.174.0 release was kicked off before the spec changes were merged, need to revert to take the spec changes

Description of changes

Reverted previous commit

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This reverts commit faa1db0, reversing
changes made to f8e6207.
@HBobertz HBobertz requested a review from a team as a code owner December 20, 2024 17:56
@aws-cdk-automation aws-cdk-automation requested a review from a team December 20, 2024 17:56
@github-actions github-actions bot added the p2 label Dec 20, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 20, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Dec 20, 2024
@HBobertz HBobertz changed the title Revert "chore(release): 2.174.0 (#32591)" chore: Revert "chore(release): 2.174.0 (#32591)" Dec 20, 2024
@HBobertz HBobertz added the pr-linter/exempt-test The PR linter will not require test changes label Dec 20, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ba64817
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@HBobertz HBobertz added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exempt-test The PR linter will not require test changes labels Dec 20, 2024
@HBobertz HBobertz changed the title chore: Revert "chore(release): 2.174.0 (#32591)" chore: revert "chore(release): 2.174.0 (#32591)" Dec 20, 2024
@HBobertz HBobertz added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Dec 20, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 20, 2024 18:49

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-cli-test-run This PR needs CLI tests run against it. labels Dec 20, 2024
@HBobertz HBobertz closed this Dec 20, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants