Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): machineImageType support AL2023 #32509

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

phuhung273
Copy link
Contributor

@phuhung273 phuhung273 commented Dec 13, 2024

Issue # (if applicable)

Closes #32496
Relate #32469

Reason for this change

  • Invalid user data on AL2023

Description of changes

  • ECS machineImageType support AL2023

Description of how you validated changes

Unit + Integration test

Instance can join cluster

image

iptables command success

image

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Dec 13, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 13, 2024 09:28
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.80%. Comparing base (2c109cf) to head (777a4ac).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32509   +/-   ##
=======================================
  Coverage   78.80%   78.80%           
=======================================
  Files         108      108           
  Lines        7159     7159           
  Branches     1319     1319           
=======================================
  Hits         5642     5642           
  Misses       1332     1332           
  Partials      185      185           
Flag Coverage Δ
suite.unit 78.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.80% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 13, 2024
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment to confirm prior to approving

packages/aws-cdk-lib/aws-ecs/lib/cluster.ts Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 13, 2024
@phuhung273 phuhung273 requested a review from GavinZZ December 14, 2024 12:47
Copy link
Contributor

mergify bot commented Dec 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 777a4ac
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Dec 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4b696bc into aws:main Dec 16, 2024
17 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2024
@phuhung273 phuhung273 deleted the ecs-al2023 branch December 16, 2024 23:03
@GavinZZ
Copy link
Contributor

GavinZZ commented Dec 17, 2024

@phuhung273 sorry that I had to revert this PR. As I just discussed with my team internally, there's known issue with the flag usage canContainersAccessInstanceRole and we're deprecating this flag (hopefully next Wednesday's release), so we should not introducing any new feature to this property that will result in more users using this feature. Apologize for the inconvenience.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(ecs): Support AL2023
3 participants