Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(elasticloadbalancingv2): add ssl policy TLS13_12 #32377

Closed
wants to merge 2 commits into from
Closed

chore(elasticloadbalancingv2): add ssl policy TLS13_12 #32377

wants to merge 2 commits into from

Conversation

KuramaeNaputo
Copy link
Contributor

@KuramaeNaputo KuramaeNaputo commented Dec 4, 2024 •
edited
Loading

Issue # (if applicable)

Closes #32307 .

Reason for this change

TLS13_12 is not exist in "SslPolicy".

https://docs.aws.amazon.com/elasticloadbalancing/latest/application/describe-ssl-policies.html

Description of changes

added TLS13_12.

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Dec 4, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 4, 2024 06:01
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Dec 4, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 24167b7
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@KuramaeNaputo
Copy link
Contributor Author

KuramaeNaputo commented Dec 4, 2024 •
edited
Loading

Hi Teams,
Code Biuld CI fails for these error.
what should I do ?

aws-cdk-lib: aws-elasticloadbalancingv2/lib/shared/enums.ts:109:3 - error JSII1004: Value 'ELBSecurityPolicy-TLS13-1-2-2021-06' is used for multiple enum values: RECOMMENDED_TLS, TLS13_12
aws-cdk-lib: 109 RECOMMENDED_TLS = 'ELBSecurityPolicy-TLS13-1-2-2021-06',
aws-cdk-lib: ~~~~~~~~~~~~~~~
aws-cdk-lib: aws-elasticloadbalancingv2/lib/shared/enums.ts:145:3
aws-cdk-lib: 145 TLS13_12 = 'ELBSecurityPolicy-TLS13-1-2-2021-06',
aws-cdk-lib: ~~~~~~~~
aws-cdk-lib: The conflicting declaration is here

I make a another PR. Which is better.
#32379

@KuramaeNaputo KuramaeNaputo mentioned this pull request Dec 4, 2024
Merged
1 task
GavinZZ pushed a commit that referenced this pull request Dec 6, 2024
@KuramaeNaputo @mergify
docs(elasticloadbalancingv2): add comment to recommended policy. (#32379
7d1dd0d 
)

### Issue # (if applicable)

Closes #32307 .

### Reason for this change
Enum SslPolicy doesn't have a TLS13_12.
When I try to add, it was failed caused by the value conflicts with the
exiting value `RECOMMENDED_TLS`.
But User will be confused. So I add a comment.

#32377 (comment)

### Description of changes

add comment to doc. 

### Description of how you validated changes

<!--Have you added any unit tests and/or integration tests?-->

### Checklist
- [x] My code adheres to the [CONTRIBUTING
GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and
[DESIGN
GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license*

---------

Co-authored-by: MasakiYamanaka <nes-m.yamanaka@nec.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@github-actions github-actions bot mentioned this pull request Jan 1, 2025
Closed
@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Jan 2, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-elasticloadbalancingv2): SslPolicy missing ELBSecurityPolicy-TLS13-1-2-2021-06
2 participants
@KuramaeNaputo @aws-cdk-automation