Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aspects): priority-ordered aspect invocation #32097

Merged
merged 76 commits into from
Nov 29, 2024
Merged
Changes from 1 commit
Commits
Show all changes
76 commits
Select commit Hold shift + click to select a range
9b9ce2f
WIP - initial Aspect work; added AspectApplication class, initial uni…
sumupitchayan Nov 11, 2024
6e6cb16
WIP - initial pass rewriting invokeAspects function, yet to be tested
sumupitchayan Nov 11, 2024
76c923b
fix build errors
sumupitchayan Nov 11, 2024
ec1d7b0
Merge remote-tracking branch 'origin/main' into sumughan/priority-ord…
sumupitchayan Nov 11, 2024
c88f355
add docstrings to AspectApplication class
sumupitchayan Nov 11, 2024
af5522b
WIP - add unit test for in-place mutation Aspect getting applied
sumupitchayan Nov 11, 2024
e8388eb
WIP - add unit test for single mutating aspect that adds a node
sumupitchayan Nov 11, 2024
3a7d05a
WIP - add 2 mutating aspects test (currently failing)
sumupitchayan Nov 11, 2024
70a437d
WIP - fix 2 mutating Aspect test
sumupitchayan Nov 12, 2024
12d54f9
WIP - remove duplicated aspects array in Aspects class
sumupitchayan Nov 12, 2024
6123866
WIP - return copied list in list() function
sumupitchayan Nov 12, 2024
5e016f6
WIP - wrap priority in AspectOptions for future extensibility
sumupitchayan Nov 12, 2024
549fbbd
WIP/refactor - make priority setter public, remove function
sumupitchayan Nov 12, 2024
7e91acb
WIP - add AspectPriority class with static default variables
sumupitchayan Nov 12, 2024
8f208b1
docstrings for AspectPriority static variables
sumupitchayan Nov 12, 2024
40f2a82
WIP - add check to prevent crossing stage boundary, fixing stage tests
sumupitchayan Nov 12, 2024
0786786
delete commented out old aspects function
sumupitchayan Nov 13, 2024
477deaa
WIP - add test using Tags Aspect
sumupitchayan Nov 13, 2024
9706de9
WIP - add warning for nested aspects, fixes unit test
sumupitchayan Nov 13, 2024
2341245
linter errors
sumupitchayan Nov 14, 2024
99910e9
WIP - fix orderedPriority array in invokeAspects to order numbers, no…
sumupitchayan Nov 18, 2024
09f8643
WIP - use PriorityQueue in invokeAspects algo; still failing 1 unit test
sumupitchayan Nov 19, 2024
f4816be
WIP - temporarily comment out assertion in nested Aspect warning test
sumupitchayan Nov 19, 2024
8141a0e
Merge branch 'main' into sumughan/priority-ordered-aspects
sumupitchayan Nov 19, 2024
a1c9642
WIP - fix example-construct-library/test/integ.example-resource.ts
sumupitchayan Nov 19, 2024
f905bb8
Merge branch 'sumughan/priority-ordered-aspects' of https://github.co…
sumupitchayan Nov 19, 2024
5f7fd33
WIP - remove console statements, try to fix broken integ tests in alpha
sumupitchayan Nov 20, 2024
dad0462
Revert "WIP - fix example-construct-library/test/integ.example-resour…
sumupitchayan Nov 20, 2024
477d003
WIP - return to stabilization loop solution.
sumupitchayan Nov 21, 2024
3ad2afe
WIP - add check that aspect priority cannot be less than priority of …
sumupitchayan Nov 21, 2024
2fee57c
Start of property test suite for aspects
rix0rrr Nov 22, 2024
13f0327
Some code improvements around the proptests
rix0rrr Nov 22, 2024
6b39626
Introduce helpers to reason about priorities
rix0rrr Nov 22, 2024
27d14d5
Fix problems with mutable state sharing
rix0rrr Nov 22, 2024
2ab5c8c
Fix state sharing of visit log as well
rix0rrr Nov 22, 2024
eaa4675
Update some more docs
rix0rrr Nov 22, 2024
83bcd50
Refactor prio code a bit
rix0rrr Nov 22, 2024
7d8f829
Add another test skeleton
rix0rrr Nov 22, 2024
9a6a8c1
WIP - add Feature Flag for aspectStabilization
sumupitchayan Nov 25, 2024
3c08fa1
WIP - fix imports in synthesis
sumupitchayan Nov 25, 2024
4254865
WIP - update README
sumupitchayan Nov 25, 2024
063acd2
Fix import order
sumupitchayan Nov 25, 2024
c650bd0
WIP - add aspect stabilization to README
sumupitchayan Nov 25, 2024
ee9a93c
Fix typos
rix0rrr Nov 25, 2024
dafc3aa
Merge branch 'sumughan/priority-ordered-aspects' of github.com:aws/aw…
rix0rrr Nov 25, 2024
e2cb8d2
Record additions of constructs and aspects
rix0rrr Nov 25, 2024
018cc41
WIP - fix duplicate invocation bug
sumupitchayan Nov 25, 2024
320d664
return false if feature flag/stabilize aspects option is undefined
sumupitchayan Nov 25, 2024
1df18e3
WIP - add back error for lower prio aspect being invoked after higher…
sumupitchayan Nov 25, 2024
aaef83f
WIP - add boolean param to afterSynth, use fc.boolean in prop tests f…
sumupitchayan Nov 25, 2024
184bd70
linter
sumupitchayan Nov 25, 2024
67398c3
Merge branch 'sumughan/priority-ordered-aspects' of https://github.co…
sumupitchayan Nov 25, 2024
6d0dd20
Rico review: add more explanation to aspectStabilization stage synth …
sumupitchayan Nov 25, 2024
81d458e
Rico doc/error comments
sumupitchayan Nov 25, 2024
ff1df34
linter: remove IAspect import from synthesis.ts
sumupitchayan Nov 25, 2024
d3409da
WIP - add 2 prop tests (currently commenting out AddingAspect)
sumupitchayan Nov 25, 2024
e4ef96c
WIP - fix test error expected string msg
sumupitchayan Nov 26, 2024
169a768
WIP - last prop test (not succeding yet tho)
sumupitchayan Nov 26, 2024
1e325dd
Don't use JSON.stringify
rix0rrr Nov 26, 2024
8161bfc
Don't keep references to constructs, always use paths
rix0rrr Nov 26, 2024
88dd0a9
Change toString to be more readable
rix0rrr Nov 26, 2024
b4f80bb
WIP - add infinite recursion unit test
sumupitchayan Nov 26, 2024
8694931
WIP - finish prop tests
sumupitchayan Nov 27, 2024
fd47e1d
Merge branch 'main' into sumughan/priority-ordered-aspects
sumupitchayan Nov 27, 2024
654c429
WIP - add feature flag version/default for future versions
sumupitchayan Nov 29, 2024
cee54b8
WIP - Rico comments on README
sumupitchayan Nov 29, 2024
42f6de2
WIP - Rico comment, remove Aspects with Third-Party Constructs sectio…
sumupitchayan Nov 29, 2024
ff7263b
WIP - Rico comment: improve error message for Aspect with lower prior…
sumupitchayan Nov 29, 2024
76c8bc4
WIP - remove unnecessary getAllConstructInScope function
sumupitchayan Nov 29, 2024
0f0b59c
Update packages/aws-cdk-lib/core/test/aspect.prop.test.ts
sumupitchayan Nov 29, 2024
0dda439
WIP - rename list to applied, also fix Warn unit test (since feature …
sumupitchayan Nov 29, 2024
f8e7d95
Merge branch 'sumughan/priority-ordered-aspects' of https://github.co…
sumupitchayan Nov 29, 2024
23c0f49
WIP - fix feature flag test
sumupitchayan Nov 29, 2024
3e62ef7
Merge branch 'main' into sumughan/priority-ordered-aspects
sumupitchayan Nov 29, 2024
c156482
WIP - fix features test (use 'V2Next' placeholder in feature flag list
sumupitchayan Nov 29, 2024
ed93f22
Merge branch 'sumughan/priority-ordered-aspects' of https://github.co…
sumupitchayan Nov 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into sumughan/priority-ordered-aspects
  • Loading branch information
sumupitchayan authored Nov 29, 2024
commit 3e62ef7d46d38ac413f5fa8e5428acb921b373da

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.