Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(codepipeline-actions): support commands action #31667
feat(codepipeline-actions): support commands action #31667
Changes from 42 commits
668b675
992ca86
f4a3ad8
fc37844
abfa49e
ad3b118
b12ba83
f593204
01d3c1b
f810819
11e5225
16304a6
a68feff
4064f47
5f095f5
1c319dc
d5e4f19
5db973b
98770d0
21652ba
b13bbc0
6bda2e3
09d4b73
deb343a
f010735
b1fb571
650a628
e8e4b17
991b400
47d61b1
06a8744
1f29d89
5d09ba9
0946882
8b256a8
f0a238d
8995a9f
8b8c5d7
c2e417e
b8f5a8c
080b073
6b82e0a
bb58063
73875e5
bfaa773
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since CFN L1 resource can take a list of items as
outputs
, I'm curious on the design decision onoutput
being one item instead of a list of artifacts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The number of output artifacts can only be 0 to 1 on the Commands action.
https://docs.aws.amazon.com/codepipeline/latest/userguide/action-reference-Commands.html#action-reference-Commands-output
So I made it
output
as an optional param that can be 0 to 1.Various actions including the commands action use the same CFn type, so it seems the CFn needs to get an array type.