Update base-service.ts

[codephi]

feat(ecs): enable custom Service Discovery with A and SRV record creation

This change allows for custom Service Discovery configurations by making the addServiceRegistry method public. This enables users to create both A and SRV DNS records simultaneously, providing greater flexibility in configuring ECS services.

Reason for this change

The current implementation of Service Discovery in ECS is limited to creating either A or SRV records, but not both simultaneously. Some use cases require the ability to define multiple types of DNS records to support various service discovery mechanisms. This change addresses that limitation by allowing custom Service Discovery configurations.

Description of changes

• Changed the addServiceRegistry method from private to public to allow external customization of service discovery settings.
• This change enables the creation of both A and SRV DNS records simultaneously, supporting a broader range of service discovery use cases.
• Updated related documentation to reflect the new capability and provide usage examples for users.

Description of how you validated changes

• Added unit tests to verify that both A and SRV records can be created simultaneously when using the updated addServiceRegistry method.
• Performed integration tests to ensure that the ECS service can be deployed with the new custom Service Discovery configuration without issues.
• Validated that existing functionality remains unchanged and that users can still create individual A or SRV records as before.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES
• Added unit and integration tests to verify new functionality.
• Updated documentation to include new usage examples and instructions.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: d709194
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[codephi]

Exemption Request

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ The title of this pull request does not follow the Conventional Commits format, see https://www.conventionalcommits.org/.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.