Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ivs-alpha): support advanced channel type #30086

Merged
merged 16 commits into from
May 24, 2024
Merged

feat(ivs-alpha): support advanced channel type #30086

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c53f546
support advanced channel type
mazyu36 May 7, 2024
c092956
fix: README
mazyu36 May 7, 2024
514da1d
Update packages/@aws-cdk/aws-ivs-alpha/README.md
mazyu36 May 7, 2024
6f66e10
Update packages/@aws-cdk/aws-ivs-alpha/README.md
mazyu36 May 7, 2024
f509cd9
Update packages/@aws-cdk/aws-ivs-alpha/lib/channel.ts
mazyu36 May 7, 2024
bbda1ff
Update packages/@aws-cdk/aws-ivs-alpha/lib/channel.ts
mazyu36 May 7, 2024
deb8909
Update packages/@aws-cdk/aws-ivs-alpha/lib/channel.ts
mazyu36 May 7, 2024
1c24353
fix: bug, docs and integ test
mazyu36 May 7, 2024
7ca984a
Update packages/@aws-cdk/aws-ivs-alpha/lib/channel.ts
mazyu36 May 7, 2024
23b89b3
Update packages/@aws-cdk/aws-ivs-alpha/lib/channel.ts
mazyu36 May 7, 2024
b8866ed
Update packages/@aws-cdk/aws-ivs-alpha/lib/channel.ts
mazyu36 May 7, 2024
323a833
Revert
mazyu36 May 7, 2024
4536c74
fix bug
mazyu36 May 8, 2024
275b495
fix: overwrite preset when standard or basic chosen
mazyu36 May 22, 2024
e09ae34
Merge branch 'main' into ivs-advanced-channel-30075
mazyu36 May 22, 2024
b4de0ba
Merge branch 'main' into ivs-advanced-channel-30075
mergify[bot] May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert 
This reverts commit 7ca984a.
  • Loading branch information
@mazyu36
mazyu36 committed May 7, 2024
commit 323a833ecc09b8d25e93dfd7cd362a79eda6fe6a
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-ivs-alpha/lib/channel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ export class Channel extends ChannelBase {
latencyMode: props.latencyMode,
name: this.physicalName,
type: props.type,
preset,
preset: props.preset,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking into account the revisions after the review, I changed it to set props.preset directly.
This is because if ChannelType is ADVANCED_SD or ADVANCED_HD, even if preset becomes undefined, Cfn will set the default value.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again, you can use the shorthand:

Suggested change
preset: props.preset,
preset,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
I had a misunderstanding about the shorthand.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh no, I'm the one who made the mistake here, it doesn't work sorry 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmussy
No problem. I reverted it.

});

this.channelArn = resource.attrArn;
Expand Down