Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli): typos in flagname, make test description accurate #29652

Closed
wants to merge 6 commits into from
Closed

docs(cli): typos in flagname, make test description accurate #29652

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
969177c
fix typos in flagname, make test description accurate
Smeb Mar 29, 2024
806b130
Merge branch 'main' into no-change-set-docs
Smeb Apr 3, 2024
3b3e693
Update packages/aws-cdk/test/diff.test.ts
scanlonp Apr 4, 2024
7ee42d9
Merge branch 'main' into no-change-set-docs
mergify[bot] Apr 4, 2024
f7931d6
Merge branch 'main' into no-change-set-docs
comcalvi May 6, 2024
5927452
Merge branch 'main' into no-change-set-docs
TheRealAmazonKendra Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/aws-cdk/lib/cdk-toolkit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ export class CdkToolkit {
let changeSet = undefined;

if (options.changeSet) {
// only perform this check if we're going to make a changeset. This check requires permissions that --no-changeset users might not have.
// only perform this check if we're going to make a changeset. This check requires permissions that --no-change-set users might not have.
const stackExists = await this.props.deployments.stackExists({
stack: stack,
deployName: stack.stackName,
Expand Down
2 changes: 1 addition & 1 deletion packages/aws-cdk/test/diff.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ describe('non-nested stacks', () => {
expect(exitCode).toBe(0);
});

test('diff does not check for stack existence when --no-changeset is passed', async () => {
test('diff does not check for stack existence when changeSet is false', async () => {
// GIVEN
const buffer = new StringWritable();

Expand Down
Loading