chore(ec2): dl2q instance type, IntanceType fixes
#29481
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -223,6 +223,11 @@ export enum InstanceClass { | |
| */ | ||
| MEMORY5_AMD_NVME_DRIVE = 'memory5-amd-nvme-drive', | ||
|
|
||
| /** | ||
| * Memory optimized instances based on AMD EPYC with local NVME drive, 5th generation | ||
| */ | ||
| R5AD = 'r5ad', | ||
|
|
||
| /** | ||
| * High memory instances (3TB) based on Intel Xeon Platinum 8176M (Skylake) processors, 1st generation | ||
| */ | ||
|
|
@@ -283,11 +288,6 @@ export enum InstanceClass { | |
| */ | ||
| U_24TB1 = 'u-24tb1', | ||
|
|
||
| /** | ||
| * Memory optimized instances that are also EBS-optimized, 5th generation | ||
| */ | ||
|
|
@@ -611,20 +611,30 @@ export enum InstanceClass { | |
| */ | ||
| STORAGE_COMPUTE_1 = 'storage-compute-1', | ||
|
|
||
| /** | ||
| * Storage/compute balanced instances, 1st generation | ||
| */ | ||
| H1 = 'h1', | ||
|
|
||
| /** | ||
| * High performance computing powered by AWS Trainium | ||
| */ | ||
| TRAINING_ACCELERATOR1 = 'training-accelerator1', | ||
|
|
||
| /** | ||
| * High performance computing powered by AWS Trainium | ||
| */ | ||
| TRN1 = 'trn1', | ||
|
|
||
| /** | ||
| * Network-optimized high performance computing powered by AWS Trainium | ||
| */ | ||
| TRAINING_ACCELERATOR1_ENHANCED_NETWORK = 'training-accelerator1-enhanced-network', | ||
|
|
||
| /** | ||
| * Network-optimized high performance computing powered by AWS Trainium | ||
| */ | ||
| TRN1N = 'trn1n', | ||
|
Comment on lines
+635
to
+637
There was a problem hiding this comment. Description for this has changed. There was a problem hiding this comment. Yeah, the aws-cdk/packages/aws-cdk-lib/aws-ec2/lib/instance-types.ts Lines 614 to 622 in fac4a9c There was a problem hiding this comment. Gotcha, thanks for clarifying. Waiting for one other PR to merge in and will approve this after that. |
||
|
|
||
| /** | ||
| * I/O-optimized instances, 3rd generation | ||
|
|
@@ -742,7 +752,7 @@ export enum InstanceClass { | |
| MEMORY_INTENSIVE_1_EXTENDED = 'memory-intensive-1-extended', | ||
|
|
||
| /** | ||
| * Memory-intensive instances, extended, 1st generation | ||
| */ | ||
| X1E = 'x1e', | ||
|
|
||
|
|
@@ -881,7 +891,7 @@ export enum InstanceClass { | |
| P2 = 'p2', | ||
|
|
||
| /** | ||
| * Parallel-processing optimized instances, 3rd generation | ||
| */ | ||
| PARALLEL3 = 'parallel3', | ||
|
|
||
|
|
@@ -891,7 +901,7 @@ export enum InstanceClass { | |
| P3 = 'p3', | ||
|
|
||
| /** | ||
| * Parallel-processing optimized instances with local NVME drive for high performance computing, 3rd generation | ||
| */ | ||
| PARALLEL3_NVME_DRIVE_HIGH_PERFORMANCE = 'parallel3-nvme-drive-high-performance', | ||
|
|
||
|
|
@@ -1199,6 +1209,16 @@ export enum InstanceClass { | |
| * Deep learning instances powered by Gaudi accelerators from Habana Labs (an Intel company), 1st generation | ||
| */ | ||
| DL1 = 'dl1', | ||
|
|
||
| /** | ||
| * Deep learning instances powered by Qualcomm AI 100 Standard accelerators, 2nd generation | ||
| */ | ||
| DEEP_LEARNING2_QUALCOMM = 'deep-learning2-qualcomm', | ||
|
|
||
| /** | ||
| * Deep learning instances powered by Qualcomm AI 100 Standard accelerators, 2nd generation | ||
| */ | ||
| DL2Q = 'dl2q', | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -1490,7 +1510,9 @@ export class InstanceType { | |
| [InstanceClass.D3]: 'd3', | ||
| [InstanceClass.STORAGE3_ENHANCED_NETWORK]: 'd3en', | ||
| [InstanceClass.D3EN]: 'd3en', | ||
| [InstanceClass.TRAINING_ACCELERATOR1]: 'trn1', | ||
| [InstanceClass.TRN1]: 'trn1', | ||
| [InstanceClass.TRAINING_ACCELERATOR1_ENHANCED_NETWORK]: 'trn1n', | ||
| [InstanceClass.TRN1N]: 'trn1n', | ||
| [InstanceClass.STORAGE_COMPUTE_1]: 'h1', | ||
| [InstanceClass.H1]: 'h1', | ||
|
|
@@ -1606,6 +1628,8 @@ export class InstanceType { | |
| [InstanceClass.MEMORY_INTENSIVE_2_XTZ_INTEL]: 'x2iezn', | ||
| [InstanceClass.DEEP_LEARNING1]: 'dl1', | ||
| [InstanceClass.DL1]: 'dl1', | ||
| [InstanceClass.DEEP_LEARNING2_QUALCOMM]: 'dl2q', | ||
| [InstanceClass.DL2Q]: 'dl2q', | ||
| }; | ||
| return new InstanceType(`${instanceClassMap[instanceClass] ?? instanceClass}.${instanceSize}`); | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are these descriptions pulled from? Some of them seem mismatched after the changes, or were they incorrect before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither
trn1nortrn1nhad a symbolic "alias" given to them when they were added, unlike every other instance class. I added one, didn't get it from anywhere really, looked up the AWS docs and tried to match the other's.