-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecs-patterns): allow custom ephemeral storage for ECS Fargate services #29275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just one question
packages/aws-cdk-lib/aws-ecs-patterns/lib/fargate/scheduled-fargate-task.ts
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-ecs-patterns/lib/fargate/scheduled-fargate-task.ts
Show resolved
Hide resolved
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #18105.
Reason for this change
In April 2021, Fargate added support for requesting additional ephemeral storage.
Support for this feature has been added to the aws-ecs package, but is still not supported by the aws-ecs-patterns package.
Description of changes
This code change adds an optional field
ephemeralStorageGiB
inpackages/aws-cdk-lib/aws-ecs-patterns/lib/base/fargate-service-base.ts
, after other fields likecpu
andmemoryLimitMiB
.Description of how you validated changes
Added unit tests and new integration tests.
Created a simple CDK application with the new constructs, and verified that it synthesized and deployed correctly.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license