Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: npm-check-updates && yarn upgrade #28434

Merged
merged 6 commits into from
Jan 10, 2024
Merged

Conversation

aws-cdk-automation
Copy link
Collaborator

Ran npm-check-updates and yarn upgrade to keep the yarn.lock file up-to-date.

@aws-cdk-automation aws-cdk-automation added auto-approve contribution/core This is a PR that came from AWS. dependencies This issue is a problem in a dependency or a pull request that updates a dependency file. labels Dec 20, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team December 20, 2023 13:52
@github-actions github-actions bot added the p2 label Dec 20, 2023
@TheRealAmazonKendra
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Jan 8, 2024

update

☑️ Nothing to do

  • -conflict [📌 update requirement]
  • #commits-behind>0 [📌 update requirement]
  • -closed [📌 update requirement]

@TheRealAmazonKendra
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Jan 8, 2024

update

✅ Branch has been successfully updated

mergify bot pushed a commit that referenced this pull request Jan 8, 2024
The update on eslint is causing the following error:

```
@aws-cdk/spec2cdk:   165:3  error  An array of Promises may be unintentional. Consider handling the promises' fulfillment or rejection with Promise.all or similar, or explicitly marking the expression as ignored with the `void` operator  @typescript-eslint/no-floating-promises
```
This PR has been separated out from [28434](#28434) because there are other failures. I am splitting these out to make clear which code is fixing which issue.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation
Copy link
Collaborator Author

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date.
Copy link
Contributor

mergify bot commented Jan 10, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 66e8275
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7d68fee into main Jan 10, 2024
11 of 12 checks passed
@mergify mergify bot deleted the automation/yarn-upgrade branch January 10, 2024 22:55
Copy link
Contributor

mergify bot commented Jan 10, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-approve contribution/core This is a PR that came from AWS. dependencies This issue is a problem in a dependency or a pull request that updates a dependency file. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants