Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix 1338] Enable to run buildup and builddown scripts without lerna globally installed #2667

Merged
merged 2 commits into from
May 29, 2019
Merged

[Fix 1338] Enable to run buildup and builddown scripts without lerna globally installed #2667

merged 2 commits into from
May 29, 2019

Conversation

Naturalclar
Copy link
Contributor

closes #1338

Modified buildup and builddown script to include $(npm bin) in PATH so that lerna does not need to be installed globally in order to run the scripts.

Pull Request Checklist

  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@Naturalclar Naturalclar requested a review from a team as a code owner May 29, 2019 11:30
@Naturalclar Naturalclar changed the title Fix/issue1338 Enable to run buildup and builddown scripts without lerna globally installed May 29, 2019
@Naturalclar Naturalclar changed the title Enable to run buildup and builddown scripts without lerna globally installed [Fix 1338] Enable to run buildup and builddown scripts without lerna globally installed May 29, 2019
eladb
eladb approved these changes May 29, 2019
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@rix0rrr rix0rrr merged commit 436694f into aws:master May 29, 2019
@Naturalclar Naturalclar deleted the fix/issue1338 branch May 29, 2019 15:15
@mattmcclean mattmcclean mentioned this pull request Jun 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tools assume lerna is installed globally
3 participants
@Naturalclar @eladb @rix0rrr