chore(pkglint): Add build:test and build:test:package scripts #2602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's bikeshedding to the max, but can we call it I don't particularly like the |
|
I'm not against that. And it's easy enough to change. Let me run a quick test to verify that it doesn't somehow break npm or the shell or whatnot, and if not, then that's cool by me! |
rix0rrr
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
build:testandbuild:test:packagescript to all packages so that they can be easily be built and tested (and optionally packaged) in topological order using a single command (lerna run build:testorlerna run build:test:package).This allows failing faster, as packages not passing unit tests will not even be built.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.