fix(batch): JobDefinition's ContainerDefinition's Image is synthesized with [Object object]

[comcalvi]

We were using Tokenization.resolve(), which uses a generic token resolver that does ${token1}${token2} instead of creating an Fn::Split object. The only reason that token existed was to mutate the L1 object after synthesis so subclasses could fill in the executionRole. The executionRole was meant to be optional for EC2 jobs and required for Fargate jobs. Setting the loggingConfig being defined would force it to be defined it for EC2 Jobs. However, the loggingConfig was always defined, because it was set to a Lazy (which could result in undefined, but that doesn't matter: it was defined during synthesis). So the executionRole was always being set:

    this.executionRole = props.executionRole ?? (this.logDriverConfig ? createExecutionRole(this, 'ExecutionRole') : undefined);

This PR makes it clear that the executionRole is created by default.

Closes #25250

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[rix0rrr]

👍

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: a700805
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).