chore: upgrade jest to ^29 #25113
Merged
chore: upgrade jest to ^29 #25113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we are on typescript >4.2 we can upgrade to jest 29. - Updated some snapshots because the snapshot format in jest 29 changed. - Cleaned up some test output by spying logs All other updates were just as a result of the version update
vinayak-kukreja
requested changes
Apr 14, 2023
| @@ -50,6 +53,8 @@ describe('validations', () => { | |||
| app.synth(); | |||
| expect(process.exitCode).toEqual(1); | |||
|
|
|||
| // eslint-disable-next-line no-console | |||
There was a problem hiding this comment.
I believe this can be removed :)
There was a problem hiding this comment.
Good catch! Updated.
corymhall
commented
Apr 14, 2023
corymhall
commented
Apr 14, 2023
vinayak-kukreja
approved these changes
Apr 14, 2023
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we are on typescript >4.2 we can upgrade to jest 29.
All other updates were just as a result of the version update
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license