Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix bump running out of memory #24983

Merged
merged 9 commits into from
Apr 11, 2023
Merged

chore: fix bump running out of memory #24983

merged 9 commits into from
Apr 11, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Apr 7, 2023

The bump performs a full build of aws-cdk-lib right now, but it doesn't need to.

  • Just run the on-bump scripts we need through ts-node instead.
  • Also make @aws-cdk/cx-api a copy of aws-cdk-lib.cx-api, same as cloud-assembly-schema. Move the on-bump script from cx-api to aws-cdk-lib.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The bump performs a full build of `aws-cdk-lib` right now, but it
doesn't need to.
@rix0rrr rix0rrr changed the title chore: fix bump chore: fix bump memory usage Apr 7, 2023
@github-actions github-actions bot added the p2 label Apr 7, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team April 7, 2023 14:20
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 7, 2023
@rix0rrr rix0rrr changed the title chore: fix bump memory usage chore: fix bump running out of memory Apr 11, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 11, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1f14bda
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 11f4ede into main Apr 11, 2023
@mergify mergify bot deleted the huijbers/fix-bump branch April 11, 2023 15:07
@mergify
Copy link
Contributor

mergify bot commented Apr 11, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants