-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(scripts): pass higher memory limit in buildup
and builddown
#24905
Conversation
buildup
and builddown
buildup
and builddown
buildup
and builddown
buildup
and builddown
Shouldn't this be 8192? Also this means that gitpod no longer works |
@hoegertn Do you know how increasing the memory limit "breaks" gitpod? Is there a safe number? |
Breaking might not be the "right" word but a default GitPod env has 8GB of RAM (https://www.gitpod.io/docs/configure/workspaces/workspace-classes) So maxing out on that limit might not be a good idea. "No longer working was too hard" I remembered lower limits on GitPod, my fault. |
Thanks for clarification! I meant to look at the gitpod setup this week and will try and see if there's a better value for it. |
6GB aka 6144 seems to work as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
I also just want to provide an FYI in case anyone is unaware and checking out this PR, if you don't need a stateful buildup or builddown, you can use |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This follows the pattern in #24425 which seems to especially happen
after #24376 when running these scripts.
Closes #24932
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license