feat(remodel): generate new package for integ tests #24391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds logic to the remodel package to create a new separate package to house all of the construct library integration tests. Remodel now finds all integration test source files and snapshots within aws-cdk-lib, copies them over to this new package, and rewrites their imports to correctly refer to aws-cdk-lib.
aws-cdk-automation
requested changes
Mar 1, 2023
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
b75721c to
8fa4a18
Compare
Adds logic for copying over a bunch of files that the integ-tests rely upon. Exports some types from `custom-resources` so they can be used by some files in the integ-tests where previously they were available implicitly.
8fa4a18 to
bed3b9c
Compare
Adds back the `runBuild` function to allow generating the alpha packages and removes the `invididual-packages/.gitignore` file so they will be commited going forward.
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logic to the remodel package to create a new separate package to house all of the construct library integration tests. Remodel now finds all integration test source files and snapshots within aws-cdk-lib, copies them over to this new package, and rewrites their imports to correctly refer to aws-cdk-lib.
Adds back the
runBuildfunction to allow generating the alpha packages and removes theinvididual-packages/.gitignorefile so they will be committed going forward.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license