feat(remodel): make codegen handle cfn-include cfn2ts-cfn-include-map #24377
Conversation
Adds functionality to cfn2ts and aws-cdk-lib gen.ts to correctly generate the map of cloudformation resource type names, to classes within aws-cdk-lib. this was previously handled by a build script in @aws-cdk/aws-cloudformation-include, but that depended on all of the individual @aws-cdk/ packages being built and parsing the code using the JSII assembly and jsii-reflect. This is not possible anymore because we can't assure aws-cdk-lib is built before aws-cdk-lib is built. However, this is pretty easy to do during code generation and in fact results in less duplication of logic.
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
| @@ -72,7 +72,7 @@ export async function main() { | |||
| const templateDir = path.join(__dirname, '..', 'lib', 'template'); | |||
| await copyTemplateFiles(templateDir, targetDir); | |||
|
|
|||
| await runBuild(targetDir); | |||
| await cleanup(targetDir); | |||
There was a problem hiding this comment.
We want to keep runBuild as well, right?
There was a problem hiding this comment.
I want to handle it in a separate task it just complicates things currently
Adds functionality to cfn2ts and aws-cdk-lib gen.ts to correctly generate the map of cloudformation resource type names, to classes within aws-cdk-lib. this was previously handled by a build script in @aws-cdk/aws-cloudformation-include, but that depended on all of the individual @aws-cdk/ packages being built and parsing the code using the JSII assembly and jsii-reflect. This is not possible anymore because we can't assure aws-cdk-lib is built before aws-cdk-lib is built.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license