feat(remodel): make tests more directory agnostic #24359
Conversation
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
| if (!_cdkVersion) { | ||
| throw new Error('Unable to determine CDK version'); | ||
| } | ||
| } | ||
| return _cdkVersion; | ||
| } | ||
|
|
||
| function findParentPkgJson(dir: string, depth: number = 1, limit: number = 5): { version: string; } { |
There was a problem hiding this comment.
for this one, and findParentTsConfigPath, if we need them in another test, let's make sure to extract to a shared utility. I am mostly just writing this comment so I remember about it, I don't think it's necessary now.
Co-authored-by: Madeline Kusters <80541297+madeline-k@users.noreply.github.com>
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Adds a bunch of changes to various unit tests to make them work regardless of their location within the repository as long as they are relative to the files they reference. Before some of these depended on the current working directory being different than they will be in aws-cdk-lib. Some of these still need to get update but will be easier to do by hand.
Additionally adds a bunch of missing build steps to
aws-cdk-libpackage.json.cdk-build.pre. These steps were all in individual modules before and built artifacts for various tests.Also adds the
runBuildfunction back into remodel. This builds everything, which unfortunately we need to do to be able to generate the alpha packages` individual pkg gen requires a bunch of the build tools and the packages that are generated themselves to actually be built first.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license