feat(remodel): call ubergen to create aws-cdk-lib #24263
Conversation
The remodel tool now calls some functions from ubergen in order to create the aws-cdk-lib package in a way that is consistent with how it is built today. Some differences from ubergen are required since it assumes that codegen has already taken place, and that L1s need to be extracted from experimental modules, which is not the case when working on aws-cdk-lib directly. Additionally makes a bunch of the functions in ubergen exported and changes them to rely on a passed configuration value instead of global variables, so that we can correctly call it in the directories that we want.
…eat/repo-restructure
…eat/repo-restructure
…eat/repo-restructure
…eat/repo-restructure
…eat/repo-restructure
…eat/repo-restructure-refactor
|
|
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
reverting whitespace change to a file with no other changes, so that git history of most recent edit to this file will stay relevant
…git history of most recent edit to this file will stay relevant
…n the scope: inline the variable since its only used once
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
tools/@aws-cdk/cfn2ts/lib/index.ts
Outdated
| /** | ||
| * Map of CFN Scopes to modules | ||
| */ | ||
| scopeMap: Record<string, string[]>; |
There was a problem hiding this comment.
Using this type and the ModuleMap interface to represent almost the same thing I found really confusing. I think we should encapsulate the process of turning the json file into the ModuleMap type. It's a bit hard to explain in comments, so I'm going to push to the branch to describe what I mean.
There was a problem hiding this comment.
See the commit here: d91b821
There was a problem hiding this comment.
I'm good to merge this now! As long as you are good with the ModuleMap changes @MrArnoldPalmer
Updates the remodel package to correctly generate the
aws-cdk-libpackage source code. Exposes a bunch of functions from within theubergenpackage, whichremodelnow calls in order to copy all of the expected packages from thepackages/@aws-cdkdirectory intopackages/aws-cdk-lib/libwhile rewriting import paths within the source code.Additionally,
ubergenreturns a list of the bundled packages, which we use to build a map of the output directories to the correct cloudformation resource scopes. This is necessary because some scopes are repeated throughout different packages and are generated different depending on whether they are generated within a package that has other potentially related scopes, or not. This scope map is output toaws-cdk-lib/scripts/scope-map.jsonfor use during code generation.cfn2tsnow reads this scope map, and will update it with newly generated directories/scopes as needed.The
verify-imports-resolve-samescript currently fails. Investigating this separately as I believe the outputs are correct and it may just be a matter of adding additional entries to package.jsonexportsfield.