fix(aws-iam): fixes #2041 sensitive module, support required to replace current cfn template construction #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cument actions which is needed for policy documents that require more than one action
rix0rrr
reviewed
Mar 20, 2019
| @@ -50,7 +50,7 @@ export abstract class PolicyPrincipal { | |||
| /** | |||
| * When this Principal is used in an AssumeRole policy, the action to use. | |||
| */ | |||
| public assumeRoleAction: string = 'sts:AssumeRole'; | |||
| public assumeRoleAction: string | Array<string> = 'sts:AssumeRole'; | |||
There was a problem hiding this comment.
We don't expose type unions at the L2 level, so we can't accept this.
There was a problem hiding this comment.
How might this be achieved otherwise? Any suggestions would be helpful.
|
I think instead of multiple assume role actions, making it so that Are you interested in taking that on? |
|
Yeah I could give it a shot. |
|
@reillykw any updates on this? |
|
I am going to close this PR as it does not look there's going to be any movement on it. Feel free to reopen in case of renewed interest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support added to PolicyDocument assume role actions which is needed for policy documents that require more than one action
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.