chore: flag previous generation instance types

[PatMyron]

https://aws.amazon.com/ec2/previous-generation/
https://instancetyp.es/

related: aws-cloudformation/cfn-lint#2267

updating some of these values for existing resources causes interruptions

---

All Submissions:

• Have you followed the guidelines in our Contributing guide?

New Features

• Have you added the new feature to an integration test?
  • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

[gitpod-io]

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: 7ee89b7
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[corymhall]

I think we should just add the message without @deprecated. These instance types are not actually deprecated, you can still create instances with these instance classes and I don't know of any plan to remove that ability.

If we ever release a CDK v3 these would get removed.

[PatMyron]

you can still create instances with these instance classes and I don't know of any plan to remove that ability

true for the oldest ~half of AWS regions, but the newest ~half of AWS regions (since 2016) and all AWS regions going forward do not support c3/m3/r3 instance type families

If we ever release a CDK v3 these would get removed

Is it not possible to leave values deprecated in future major versions as well? There are other @deprecated values that would need to be kept like Lambda runtime values that cannot be created or updated but can still exist in existing stacks:
#19938

[TheRealAmazonKendra]

The link your posted specifically calls out that they're continuing to support older instance types.

AWS offers Previous Generation Instances for users who have optimized their applications around these instances and have yet to upgrade. Previous Generation Instances are still fully supported and retain the same features and functionality. Previous Generation Instances are available through the AWS Management Console, AWS CLI, and EC2 API tools.

Given that, I don't think we should mark these as deprecated. While ~half of the regions don't support the older ones, that's still ~half that do. I would support adding a warning and adding documentation that says they're older generations, but not deprecating them altogether at this point.

[PatMyron]

I would support adding a warning

Is there another annotation to do that visibly other than @deprecated? Enabled editing my branch by maintainers, so feel free to switch / drop annotations as desired to merge 👍

[TheRealAmazonKendra]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.