chore(v2): literate examples missing from v2 #18118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The literate examples are `test/*.lit.ts` files that are included in the `README`s by jsii. Ubergen didn't copy `test` files, because there were issues with the test dependency `@aws-cdk/assert` which couldn't be included into `aws-cdk-lib`. In this PR, add copying of only the literate source files to `ubergen` so that we can include the examples again in READMEs. It is safe since those are integration tests that don't depend on `@aws-cdk/assert` (which is only used by unit tests).
|
|
njlynch
reviewed
Dec 21, 2021
| @@ -554,7 +572,6 @@ const IGNORED_FILE_NAMES = new Set([ | |||
| '.npmignore', | |||
| 'node_modules', | |||
| 'package.json', | |||
| 'test', | |||
There was a problem hiding this comment.
Should this really be removed? Looks like it should stay, based on a quick skim of where it's used.
corymhall
approved these changes
Dec 28, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
The literate examples are `test/*.lit.ts` files that are included in the `README`s by jsii. Ubergen didn't copy `test` files, because there were issues with the test dependency `@aws-cdk/assert` which couldn't be included into `aws-cdk-lib`. In this PR, add copying of only the literate source files to `ubergen` so that we can include the examples again in READMEs. It is safe since those are integration tests that don't depend on `@aws-cdk/assert` (which is only used by unit tests). Updated some EKS integ tests to no longer depend on test files that don't get copied by this mechanism (`./util.ts`). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The literate examples are
test/*.lit.tsfiles that are includedin the
READMEs by jsii.Ubergen didn't copy
testfiles, because there were issues with thetest dependency
@aws-cdk/assertwhich couldn't be included intoaws-cdk-lib.In this PR, add copying of only the literate source files to
ubergenso that we can include the examples again in READMEs. It is safe since
those are integration tests that don't depend on
@aws-cdk/assert(which is only used by unit tests).
Updated some EKS integ tests to no longer depend on test files that
don't get copied by this mechanism (
./util.ts).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license