Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipelines): can't use exports from very long stack names #18039

Merged
merged 5 commits into from
Dec 16, 2021

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Dec 15, 2021

The variable namespace identifier in CodePipeline allows a maximum of
100 characters. If we ever come up with an identifier that would be
too long, trim it down.

While writing tests for this, discovered that actions exhibited the same
length issues, and did the same there too.

Fixes #17436.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The variable namespace identifier in CodePipeline allows a maximum of
100 characters. If we ever come up with an identifier that would be
too long, trim it down.

While writing tests for this, discovered that actions exhibited the same
length issues, and did the same there too.

Fixes #17436.
@rix0rrr rix0rrr requested a review from a team December 15, 2021 14:04
@rix0rrr rix0rrr self-assigned this Dec 15, 2021
@gitpod-io
Copy link

gitpod-io bot commented Dec 15, 2021

@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label Dec 15, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 15, 2021
@rix0rrr
Copy link
Contributor Author

rix0rrr commented Dec 15, 2021

npm ERR! notarget No matching version found for @aws-cdk/aws-lex@1.135.0.

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Dec 15, 2021

@aws-cdk/lambda-layer-node-proxy-agent: �[91mnpm ERR! code E503
@aws-cdk/lambda-layer-node-proxy-agent: �[0m�[91mnpm ERR! 503 Service Unavailable - GET https://registry.npmjs.org/socks-proxy-agent - Service Unavailable

Fun beans

Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify
Copy link
Contributor

mergify bot commented Dec 16, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 6c3c1a7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 465dabf into master Dec 16, 2021
@mergify mergify bot deleted the huijbers/pipelines-names branch December 16, 2021 01:14
@mergify
Copy link
Contributor

mergify bot commented Dec 16, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
The variable namespace identifier in CodePipeline allows a maximum of
100 characters. If we ever come up with an identifier that would be
too long, trim it down.

While writing tests for this, discovered that actions exhibited the same
length issues, and did the same there too.

Fixes aws#17436.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/pipelines CDK Pipelines library contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(pipelines): envFromCfnOutputs does not work when stacks have a long artifactId
3 participants