Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include RELEASE_NOTES in packed distribution (backport #17118) #17119

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 22, 2021

This is an automatic backport of pull request #17118 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

We now create and generate a `RELEASE_NOTES.md` file as part of our build, with
the intent to use it for our GitHub release publishing. See (#16942) and
cdklabs/aws-delivlib#1044.

What I missed is that after the build, we pack, and then only include what ends
up in `./dist` in the final build artifact that goes to publishing. This fix
includes the release notes in the dist folder so it will be picked up and used
by the release process.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

(cherry picked from commit 260df31)
@gitpod-io
Copy link

gitpod-io bot commented Oct 22, 2021

@github-actions github-actions bot added the @aws-cdk/aws-cloudwatch Related to Amazon CloudWatch label Oct 22, 2021
@njlynch njlynch assigned njlynch and unassigned madeline-k Oct 22, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7e2f8f3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1a148d2 into v2-main Oct 22, 2021
@mergify mergify bot deleted the mergify/bp/v2-main/pr-17118 branch October 22, 2021 15:43
@mergify
Copy link
Contributor Author

mergify bot commented Oct 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants