Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(appmesh): allow setting the DnsResponseType in DNS ServiceDiscovery #15388

Merged
merged 13 commits into from
Jul 6, 2021
Merged

feat(appmesh): allow setting the DnsResponseType in DNS ServiceDiscovery #15388

merged 13 commits into from
Jul 6, 2021

Conversation

Seiya6329
Copy link
Contributor

@Seiya6329 Seiya6329 commented Jul 1, 2021 •
edited by skinny85
Loading

REV:

  • Adding new property responseType to DNS ServiceDiscovery
  • Changing .cloudMap() factory method to accept positional argument
  • Adding a runtime-error to check if the service discovery is defined when listener is specified

BREAKING CHANGE: ServiceDiscovery.cloudMap() method has been changed to accept positional arguments

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 1, 2021

@Seiya6329 Seiya6329 closed this Jul 1, 2021
@skinny85
Copy link
Contributor

skinny85 commented Jul 1, 2021

This was a fast one 😃.

@Seiya6329 Seiya6329 reopened this Jul 1, 2021
@Seiya6329
Copy link
Contributor Author

@skinny85 - I realized I submitted the PR directly into main repo before having an internal review but ready now!

@Seiya6329
Copy link
Contributor Author

Checking the reason for build failure.

skinny85
skinny85 previously requested changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. A few suggestion/questions.

@mergify mergify bot dismissed skinny85’s stale review July 2, 2021 06:51

Pull request has been modified.

@Seiya6329 Seiya6329 requested a review from skinny85 July 2, 2021 20:04
@Seiya6329
Copy link
Contributor Author

@skinny85 - I wish there is revoke button on re-request review. Fixing the conflicts now.

@Seiya6329 Seiya6329 changed the title feat(appmesh): Adding ResponseType and validation check feat(appmesh): adding ResponseType and validation check Jul 2, 2021
skinny85
skinny85 previously requested changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost perfect! A few last minor comments.

@mergify mergify bot dismissed skinny85’s stale review July 5, 2021 04:58

Pull request has been modified.

@Seiya6329 Seiya6329 requested a review from skinny85 July 5, 2021 05:08
@Seiya6329
Copy link
Contributor Author

REV3:

  • Changing the error message for the serviceDiscovery error.
  • Adding the renderServiceDiscovery function.
  • Changing the name to LOAD_BALANCER for the enum.

skinny85
skinny85 previously approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Seiya6329 and others added 2 commits July 6, 2021 09:16
@Seiya6329 @skinny85
Update packages/@aws-cdk/aws-appmesh/README.md
1f465ef 
Co-authored-by: Adam Ruka <adamruka@amazon.com>
@Seiya6329 @skinny85
Update packages/@aws-cdk/aws-appmesh/lib/virtual-node.ts
781e846 
Co-authored-by: Adam Ruka <adamruka@amazon.com>
@mergify mergify bot dismissed skinny85’s stale review July 6, 2021 16:17

Pull request has been modified.

@Seiya6329 Seiya6329 requested review from skinny85 July 6, 2021 16:20
@Seiya6329
Copy link
Contributor Author

@skinny85 - Sorry, I think I overwritten your approval after committing the last two suggestions.

@skinny85 skinny85 changed the title feat(appmesh): adding ResponseType and validation check feat(appmesh): allow setting the DnsResponseType in DNS ServiceDiscovery Jul 6, 2021
@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 597c28d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 647acfa into aws:master Jul 6, 2021
@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

upparekh pushed a commit to upparekh/aws-cdk that referenced this pull request Jul 8, 2021
@Seiya6329 @upparekh
feat(appmesh): allow setting the DnsResponseType in DNS ServiceDiscov…
44a4d3c 
…ery (aws#15388)

#### REV:
- Adding new property `responseType` to DNS `ServiceDiscovery`
- Changing `.cloudMap()` factory method to accept positional argument
- Adding a runtime-error to check if the service discovery is defined when listener is specified

BREAKING CHANGE: `ServiceDiscovery.cloudMap()` method has been changed to accept positional arguments

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@Seiya6329 @hollanddd
feat(appmesh): allow setting the DnsResponseType in DNS ServiceDiscov…
f02f10f 
…ery (aws#15388)

#### REV:
- Adding new property `responseType` to DNS `ServiceDiscovery`
- Changing `.cloudMap()` factory method to accept positional argument
- Adding a runtime-error to check if the service discovery is defined when listener is specified

BREAKING CHANGE: `ServiceDiscovery.cloudMap()` method has been changed to accept positional arguments

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinny85 skinny85 Awaiting requested review from skinny85

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Seiya6329 @skinny85 @aws-cdk-automation