Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable project references in build #1466

Merged
merged 9 commits into from
Jan 3, 2019
Merged

chore: enable project references in build #1466

merged 9 commits into from
Jan 3, 2019

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jan 2, 2019 •
edited
Loading

Creating project references enables quick (and more correct) full-repo
rebuilds.

This change brings in the new JSII version with aws/jsii#343

Pull Request Checklist

  • Testing
    • Unit test added
    • CLI change?: manually run integration tests and paste output as a PR comment
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@rix0rrr
chore: set up (manual) project references in preparation for an upcom…
d2855de 
…ing jsii change

Creating project references enables quick (and more correct) full-repo
rebuilds, as well as allowing Visual Studio to do Find References across
all packages in the repository.
@rix0rrr rix0rrr requested review from RomainMuller and eladb January 2, 2019 09:47
@rix0rrr rix0rrr requested a review from a team as a code owner January 2, 2019 09:47
eladb
eladb reviewed Jan 2, 2019
View reviewed changes
packages/@aws-cdk/tsconfig.json Outdated
"__comment__": "This file is necessary to make transitive Project References in TypeScript work",
"files": [],
"references": [
{ "path": "alexa-ask" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we generate this file upon install.sh?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, potentially. Better to do it in build.sh I think then, otherwise adding a package will break the build until you run install.sh which is going to be very unintuitive.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything but manually requiring people to edit this

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Jan 3, 2019

fwiw, the build is failing because the Maven release of jsii 0.7.13 hasn't completely propagated through the system yet.

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Jan 3, 2019

Nexus release:

[INFO] Released 
[INFO] ------------------------------------------------------------------------ 
[INFO] BUILD SUCCESS 
[INFO] ------------------------------------------------------------------------ 
[INFO] Total time: 1:30.109s 
[INFO] Finished at: Thu Jan 03 15:37:01 UTC 2019 
[INFO] Final Memory: 16M/208M

and yet:

@aws-cdk/cx-api: [ERROR] Failed to execute goal on project cdk-cx-api: Could not resolve dependencies for project software.amazon.awscdk:cdk-cx-api:jar:0.21.0: Could not find artifact software.amazon.jsii:jsii-runtime:jar:0.7.13 in local0 (file:///codebuild/output/src427005584/src/github.com/awslabs/aws-cdk/packages/@aws-cdk/cx-api/dist/java) -> [Help 1]

@rix0rrr rix0rrr changed the title chore: set up (manual) project references in preparation for an upcom… chore: enable project references in build Jan 3, 2019
@rix0rrr rix0rrr merged commit 0f8362d into master Jan 3, 2019
@rix0rrr rix0rrr deleted the huijbers/project-references branch January 3, 2019 17:06
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
@JeremyJonas JeremyJonas mentioned this pull request Jul 10, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

@RomainMuller RomainMuller Awaiting requested review from RomainMuller

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rix0rrr @eladb @NGL321