Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): use parameter store refs instead of exports #13804

Closed
wants to merge 23 commits into from

Conversation

corrjo
Copy link

@corrjo corrjo commented Mar 25, 2021


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 25, 2021

@github-actions github-actions bot added the @aws-cdk/core Related to core CDK functionality label Mar 25, 2021
Elad Ben-Israel and others added 3 commits March 25, 2021 13:02
Add `go` configuration to the `monocdk` and `aws-cdk-lib` packages.

Resolves aws/jsii#2611

The following jsii bugs were fixed to enable this:

- [x] aws/jsii#2648
- [x] aws/jsii#2649
- [x] aws/jsii#2647
- [x] aws/jsii#2617
- [x] aws/jsii#2632
- [x] aws/jsii#2651
- [x] aws/jsii#2508
- [x] aws/jsii#2692
- [x] aws/jsii#2700
- [x] aws/jsii#2702

---

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
There is a typo in the UserData script that install the CodeDeploy Agent
on EC2 instances for the server DeploymentGroup.

Fixes aws#13755

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

version
@corrjo corrjo marked this pull request as draft April 2, 2021 18:50
@corrjo
Copy link
Author

corrjo commented Apr 6, 2021

Hey @skinny85, @rix0rrr I finally found some cycles to work on this (re: #13184) but hit a broken test in @aws-cdk/aws-eks-legacy I started working on a fix but also noticed

Annotations.of(this).addWarning('The @aws-cdk/aws-eks-legacy module will no longer be released as part of the AWS CDK starting March 1st, 2020. Please refer to https://github.com/aws/aws-cdk/issues/5544 for upgrade instructions');
is it worth spending time to fix this?

rix0rrr
rix0rrr previously requested changes Apr 6, 2021
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the intent, but this is really a fundamental design change that's going to need discussion. exports definitely have value which should be taken into account.

I recommend you open up an RFC first with a proposal and a motivation and thinking through some of the impacts.

@mergify mergify bot dismissed rix0rrr’s stale review April 6, 2021 16:58

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 01873bd
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@corrjo
Copy link
Author

corrjo commented Apr 8, 2021

Thanks for the intent, but this is really a fundamental design change that's going to need discussion. exports definitely have value which should be taken into account.

I recommend you open up an RFC first with a proposal and a motivation and thinking through some of the impacts.

aws/aws-cdk-rfcs#311

@corrjo
Copy link
Author

corrjo commented Apr 14, 2021

relates to #12778

@TheRealAmazonKendra
Copy link
Contributor

This PR has been deemed to be abandoned, and will be closed. Please create a new PR for these changes if you think this decision has been made in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/core Related to core CDK functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants