-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): use parameter store refs instead of exports #13804
Conversation
Add `go` configuration to the `monocdk` and `aws-cdk-lib` packages. Resolves aws/jsii#2611 The following jsii bugs were fixed to enable this: - [x] aws/jsii#2648 - [x] aws/jsii#2649 - [x] aws/jsii#2647 - [x] aws/jsii#2617 - [x] aws/jsii#2632 - [x] aws/jsii#2651 - [x] aws/jsii#2508 - [x] aws/jsii#2692 - [x] aws/jsii#2700 - [x] aws/jsii#2702 --- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
There is a typo in the UserData script that install the CodeDeploy Agent on EC2 instances for the server DeploymentGroup. Fixes aws#13755 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* version
* don't use dependent packages * builds * fix test
Hey @skinny85, @rix0rrr I finally found some cycles to work on this (re: #13184) but hit a broken test in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the intent, but this is really a fundamental design change that's going to need discussion. exports definitely have value which should be taken into account.
I recommend you open up an RFC first with a proposal and a motivation and thinking through some of the impacts.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
relates to #12778 |
924c117
to
ebfd5f2
Compare
This PR has been deemed to be abandoned, and will be closed. Please create a new PR for these changes if you think this decision has been made in error. |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license