feat(lambda-python): support poetry packaging for PythonFunction #11850
Conversation
|
|
There was a problem hiding this comment.
Looks solid. Minor request about integ tests (would be great if you could consolidate the other tests as well).
Please refer to the contribution guide for more info about integ tests.
packages/@aws-cdk/aws-lambda-python/test/integ.function.poetry.py27.ts
Outdated
Show resolved
Hide resolved
|
@eladb : Replaced the multiple files for integration tests with a single file that has multiple functions. Happy to consolidate the various |
|
Also wanted to mention that I couldn't actually run |
|
Thank you, @eladb! |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…1891) Following the request from @eladb in #11850 (review), consolidating some of the integration tests in the package. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…#11850) This PR adds [poetry](https://python-poetry.org/) support to building Lambda dependencies for the PythonFunction. I used the pipenv setup for inspiration. I'm not very familiar with writing integration tests, so there's a possibility that I could've missed something. Closes aws#11753. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…s#11891) Following the request from @eladb in aws#11850 (review), consolidating some of the integration tests in the package. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…#11850) This PR adds [poetry](https://python-poetry.org/) support to building Lambda dependencies for the PythonFunction. I used the pipenv setup for inspiration. I'm not very familiar with writing integration tests, so there's a possibility that I could've missed something. Closes aws#11753. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…s#11891) Following the request from @eladb in aws#11850 (review), consolidating some of the integration tests in the package. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR adds poetry support to building Lambda dependencies for the PythonFunction.
I used the pipenv setup for inspiration. I'm not very familiar with writing integration tests, so there's a possibility that I could've missed something.
Closes #11753.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license