Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include attributions for aws-cdk-lib #11413

Merged
merged 2 commits into from
Nov 11, 2020

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Nov 11, 2020

In the v2 branch, aws-cdk-lib will be made public. Hence, include
attributions for these.

Update the pkglint rule to also check aws-cdk-lib in the master
branch.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@nija-at nija-at requested a review from RomainMuller November 11, 2020 11:13
@nija-at nija-at self-assigned this Nov 11, 2020
@gitpod-io
Copy link

gitpod-io bot commented Nov 11, 2020

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 11, 2020
@nija-at nija-at added the pr/do-not-merge This PR should not be merged at this time. label Nov 11, 2020
@nija-at nija-at removed the pr/do-not-merge This PR should not be merged at this time. label Nov 11, 2020
@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8545350 into master Nov 11, 2020
@mergify mergify bot deleted the nija-at/awscdklib-attributions branch November 11, 2020 11:45
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: cdf363e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants