-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: install standard-version before running bump #11312
Conversation
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make more sense to simply run yarn
from the root ?
Debatable, the script used to be self-contained with @eladb How strongly do you feel about it? :) |
It's not really the same thing because we are now installing the module locally so it can potentially "pollute" our node modules |
Fair enough, i'll change |
Sorry about this F up |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR migrated our CLI usage of
standard-version
to be used in code as a library. But the library is not installed anywhere.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license