Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: install standard-version before running bump #11312

Merged
merged 8 commits into from
Nov 5, 2020

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Nov 5, 2020

This PR migrated our CLI usage of standard-version to be used in code as a library. But the library is not installed anywhere.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 5, 2020

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 5, 2020
@mergify
Copy link
Contributor

mergify bot commented Nov 5, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make more sense to simply run yarn from the root ?

@iliapolo
Copy link
Contributor Author

iliapolo commented Nov 5, 2020

Would it make more sense to simply run yarn from the root ?

Debatable, the script used to be self-contained with npx, this simulates that.

@eladb How strongly do you feel about it? :)

@eladb
Copy link
Contributor

eladb commented Nov 5, 2020

It's not really the same thing because we are now installing the module locally so it can potentially "pollute" our node modules

@iliapolo
Copy link
Contributor Author

iliapolo commented Nov 5, 2020

It's not really the same thing because we are now installing the module locally so it can potentially "pollute" our node modules

Fair enough, i'll change

@iliapolo iliapolo requested a review from eladb November 5, 2020 15:21
@iliapolo iliapolo requested a review from eladb November 5, 2020 15:30
@eladb
Copy link
Contributor

eladb commented Nov 5, 2020

Sorry about this F up

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 4739383
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Nov 5, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8478153 into master Nov 5, 2020
@mergify mergify bot deleted the epolon/install-standard-version-when-needed branch November 5, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants