-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cognito): user pool resource server #11118
Conversation
Also allow adding resource server via userPool.addResourceServer
@nija-at All good here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments below.
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@nija-at Updated. Need your feedback on the dependency pattern though. When pairing with an app client, the resource server and its scopes need to be created first before the client can reference it. I realized this when I was doing the integ test that sometimes the client will be created before the resource server, which will result in the stack failing since the scope can't be found. We need to create a dependency to ensure it happens in the right order. I did
Is this the best way or should we do this internally in UserPoolClient, and accept a |
packages/@aws-cdk/aws-cognito/test/integ.user-pool-resource-server.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
…rver.ts Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@nija-at Suggested changes made. |
Hey @iRoachie - I made a small adjustment to the API in this PR - 2715726#diff-c27648629074407952dc3ab03cdf2ec0193f1eb61372913b8c92265051cc553a. Let me know if you think if it's better. |
@nija-at Definitely better. Removes the possibility for misspelling scope name between server and client 👍 |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thanks again for your patience @nija-at 🥇 |
Also allow adding resource server via
userPool.addResourceServer
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license