Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make vpcSubnets and vpcPlacement consistent between Cluster and Instance #9776

Closed
skinny85 opened this issue Aug 17, 2020 · 0 comments · Fixed by #10093
Closed

Make vpcSubnets and vpcPlacement consistent between Cluster and Instance #9776

skinny85 opened this issue Aug 17, 2020 · 0 comments · Fixed by #10093
Assignees
@njlynch
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Milestone
[GA] RDS

Comments

@skinny85
Copy link
Contributor

See related issue: #9762
@skinny85 skinny85 added this to the RDS to 'stable' milestone Aug 17, 2020
@skinny85 skinny85 self-assigned this Aug 17, 2020
@skinny85 skinny85 added @aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Aug 17, 2020
@njlynch njlynch assigned njlynch and unassigned skinny85 Sep 1, 2020
njlynch added a commit that referenced this issue Sep 1, 2020
@njlynch
feat(rds): rename DatabaseInstanceNewProps.vpcPlacement to vpcSubnets
0836bae 
Deprecate the `vpcPlacement` property in favor of `vpcSubnets` to be more
consistent with the Cluster naming (and general convention across the CDK).

fixes #9776
@njlynch njlynch mentioned this issue Sep 1, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Sep 1, 2020
@mergify mergify bot closed this as completed in #10093 Sep 1, 2020
mergify bot pushed a commit that referenced this issue Sep 1, 2020
@njlynch
feat(rds): rename DatabaseInstanceNewProps.vpcPlacement to vpcSubnets (…
ec423ef 
…#10093)

Deprecate the `vpcPlacement` property in favor of `vpcSubnets` to be more
consistent with the Cluster naming (and general convention across the CDK).

fixes #9776


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njlynch njlynch

Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
[GA] RDS
Development

Successfully merging a pull request may close this issue.

feat(rds): rename DatabaseInstanceNewProps.vpcPlacement to vpcSubnets aws/aws-cdk
3 participants
@skinny85 @njlynch @SomayaB