Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cfn-include] Add support for retrieving Rule objects from the template #9712

Closed
4 tasks
skinny85 opened this issue Aug 14, 2020 · 0 comments · Fixed by #9783
Closed
4 tasks

[cfn-include] Add support for retrieving Rule objects from the template #9712

skinny85 opened this issue Aug 14, 2020 · 0 comments · Fixed by #9783
Assignees
@skinny85
Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Milestone
[DevPreview] @aws...

Comments

@skinny85
Copy link
Contributor

Similarly like allow retrieving Parameters, Conditions, Resources, and Outputs from the included template today (see the module ReadMe), do the same for Rule objects.

  • Add a new method to CfnInclude, public getRule(name: string): CfnRule
  • Create the CfnRule instances in the constructor of CfnInclude
  • Stop rendering the Rules section of the template unchanged here
  • Unit tests
@github-actions github-actions bot added the @aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package label Aug 14, 2020
@skinny85 skinny85 mentioned this issue Aug 14, 2020
Closed
@skinny85 skinny85 added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Aug 14, 2020
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Aug 18, 2020
@skinny85
feat(cfn-include): add support for retrieving Rule objects from the t…
30ce3ae 
…emplate

Fixes aws#9712
@skinny85 skinny85 mentioned this issue Aug 18, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Aug 18, 2020
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Aug 19, 2020
@skinny85
feat(cfn-include): add support for retrieving Rule objects from the t…
4f66e5f 
…emplate

Fixes aws#9712
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Aug 19, 2020
@skinny85
feat(cfn-include): add support for retrieving Rule objects from the t…
5a63a7b 
…emplate

Fixes aws#9712
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Aug 19, 2020
@skinny85
feat(cfn-include): add support for retrieving Rule objects from the t…
d82686d 
…emplate

Fixes aws#9712
@mergify mergify bot closed this as completed in #9783 Aug 19, 2020
mergify bot pushed a commit that referenced this issue Aug 19, 2020
@skinny85
feat(cfn-include): add support for retrieving Rule objects from the t…
e4720bf 
…emplate (#9783)

Fixes #9712

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
[DevPreview] @aws-cdk/cloudformation-...
Development

Successfully merging a pull request may close this issue.

feat(cfn-include): add support for retrieving Rule objects from the template skinny85/aws-cdk
2 participants
@skinny85 @SomayaB