Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-eks] Default masters role #9463

Closed
eladb opened this issue Aug 5, 2020 · 0 comments · Fixed by #9464
Closed

[aws-eks] Default masters role #9463

eladb opened this issue Aug 5, 2020 · 0 comments · Fixed by #9464
Assignees
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service feature-request A feature should be added or improved.

Comments

@eladb
Copy link
Contributor

eladb commented Aug 5, 2020

Today, in order to issue kubectl commands against an EKS cluster, the mastersRole must be explicitly defined. This creates quite a lot of friction for users.

Moreoever, the kubectlEnabled option was confused to "solve" this problem because it falls back to use the stock CFN resource, which grants masters permissions to the user that creates the cluster (so kubectl commands can be issued).

To solve this, we should simply auto-generate a masters role if a role is not defined.

eladb pushed a commit that referenced this issue Aug 5, 2020
If `mastersRole` is not specified, we now define a default IAM role that can be assumed by anyone (with permissions) in the account.

This will allow users to interact with the cluster through `kubectl` by issuing the `aws eks update-kubeconfig` command with the appropriate `--role-arn` option, as specified in the CFN output.

Fixes #9463
eladb pushed a commit that referenced this issue Aug 5, 2020
    
If `mastersRole` is not specified, we now define a default IAM role that can be assumed by anyone (with permissions) in the account.
    
If `mastersRole` is not specified, we now define a default IAM role that can be assumed by anyone (with permissions) in the account.
    
This will allow users to interact with the cluster through `kubectl` by issuing the `aws eks update-kubeconfig` command with the appropriate `--role-arn` option, as specified in the CFN output.
    
Fixes #9463
@SomayaB SomayaB changed the title eks: Default masters role [eks] Default masters role Aug 5, 2020
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Aug 5, 2020
@SomayaB SomayaB added in-progress This issue is being actively worked on. feature-request A feature should be added or improved. labels Aug 5, 2020
@mergify mergify bot closed this as completed in #9464 Aug 5, 2020
mergify bot pushed a commit that referenced this issue Aug 5, 2020
If `mastersRole` is not specified, we now define a default IAM role that can be assumed by anyone (with permissions) in the account.
        
This will allow users to interact with the cluster through `kubectl` by issuing the `aws eks update-kubeconfig` command with the appropriate `--role-arn` option, as specified in the CFN output.
    
Fixes #9463


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@iliapolo iliapolo added this to the EKS Dev Preview milestone Aug 10, 2020
eladb pushed a commit that referenced this issue Aug 10, 2020
If `mastersRole` is not specified, we now define a default IAM role that can be assumed by anyone (with permissions) in the account.
        
This will allow users to interact with the cluster through `kubectl` by issuing the `aws eks update-kubeconfig` command with the appropriate `--role-arn` option, as specified in the CFN output.
    
Fixes #9463


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@iliapolo iliapolo changed the title [eks] Default masters role [aws-eks] Default masters role Aug 16, 2020
@iliapolo iliapolo removed the in-progress This issue is being actively worked on. label Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service feature-request A feature should be added or improved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants