Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[appsync] I want to fix example code #8764

Closed
ufoo68 opened this issue Jun 27, 2020 · 1 comment
Closed

[appsync] I want to fix example code #8764

ufoo68 opened this issue Jun 27, 2020 · 1 comment
Assignees
Labels
@aws-cdk/aws-appsync Related to AWS AppSync documentation This is a problem with documentation. feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@ufoo68
Copy link
Contributor

ufoo68 commented Jun 27, 2020

doc page: https://docs.aws.amazon.com/cdk/api/latest/docs/aws-appsync-readme.html

I want to fix example code

const userPool = new UserPool(this, 'UserPool'{
      userPoolName: 'myPool',
    });

to

const userPool = new UserPool(this, 'UserPool', {
      userPoolName: 'myPool',
    });

This is a 📕 documentation issue

@ufoo68 ufoo68 added documentation This is a problem with documentation. feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 27, 2020
@github-actions github-actions bot added the @aws-cdk/aws-appsync Related to AWS AppSync label Jun 27, 2020
mergify bot pushed a commit that referenced this issue Jun 29, 2020
### Commit Message
chore(appsync):  Fix sample code on README

- Add comma on `new UserPool()`

#8764 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@shivlaks
Copy link
Contributor

shivlaks commented Jul 7, 2020

closed by #8765

@shivlaks shivlaks closed this as completed Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-appsync Related to AWS AppSync documentation This is a problem with documentation. feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants