Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cloudformation-include] Add support for YAML templates #8745

Closed
1 of 2 tasks
comcalvi opened this issue Jun 25, 2020 · 3 comments · Fixed by #8746
Closed
1 of 2 tasks

[cloudformation-include] Add support for YAML templates #8745

comcalvi opened this issue Jun 25, 2020 · 3 comments · Fixed by #8746
Assignees
Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@comcalvi
Copy link
Contributor

Adding support for YAML templates, since cloudformation accepts both JSON and YAML.

Use Case

Cloudformation supports both YAML and JSON templates, so the CDK should as well.

Proposed Solution

I will be opening a PR to address this.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@comcalvi comcalvi added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 25, 2020
@github-actions github-actions bot added the @aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package label Jun 25, 2020
@asterikx
Copy link
Contributor

asterikx commented Jun 27, 2020

Just came across this tool https://github.com/awslabs/aws-cfn-template-flip for converting CloudFormation templates between JSON and YAML (seen in this comment here, credits to @rrrix). That might be helpful.

Btw, what's the motivation for this? Since the synthesized templates are "internal" to CDK, shouldn't you care too much about their format?

@skinny85
Copy link
Contributor

Btw, what's the motivation for this? Since the synthesized templates are "internal" to CDK, shouldn't you care too much about their format?

This is for the cloudformation-includemodule - this adds support for ingesting a CloudFormation template in YAML format, in addition to JSON. So it's not changing anything in CDK internals, it's about accepting another format as input.

@asterikx
Copy link
Contributor

Sorry, missed the module prefix in the title. Please ignore my comment ;-)

@mergify mergify bot closed this as completed in #8746 Jun 29, 2020
mergify bot pushed a commit that referenced this issue Jun 29, 2020
Fixes #8745 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants