Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Instance Monitoring option to AutoScaling Groups #8212

Closed
1 of 2 tasks
rbobrowicz opened this issue May 26, 2020 · 1 comment · Fixed by #8213
Closed
1 of 2 tasks

Add Instance Monitoring option to AutoScaling Groups #8212

rbobrowicz opened this issue May 26, 2020 · 1 comment · Fixed by #8213
Assignees
Labels
@aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@rbobrowicz
Copy link
Contributor

Right now all Autoscaling Groups created by CDK have detailed monitoring enabled, incurring an extra cost for every instance on the CDK user. Users should be able to choose if they need/want detailed monitoring.

Use Case

Creating an Autoscaling Group with basic monitoring for cases where detailed monitoring is not needed/wanted in order to save CloudWatch costs.

Proposed Solution

Add an optional boolean instanceMonitoring property to AutoScalingGroupProps. CloudFormation already supports the field on the LaunchConfiguration object.

The field should be optional and default to true, maintaining current behavior and matching CloudFormation.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@rbobrowicz rbobrowicz added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 26, 2020
rbobrowicz added a commit to rbobrowicz/aws-cdk that referenced this issue May 26, 2020
Gives users the option to choose between detailed and basic monitoring.
Defaults to detailed when not specified, maintaining current behavior.
rbobrowicz added a commit to rbobrowicz/aws-cdk that referenced this issue May 26, 2020
Gives users the option to choose between detailed and basic monitoring.
Defaults to detailed when not specified, maintaining current behavior.

fixes aws#8212
rbobrowicz added a commit to rbobrowicz/aws-cdk that referenced this issue May 26, 2020
Gives users the option to choose between detailed and basic monitoring.
Defaults to detailed when not specified, maintaining current behavior.

fixes aws#8212
@SomayaB SomayaB added the @aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling label May 27, 2020
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label May 27, 2020
@NetaNir NetaNir added effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels May 28, 2020
rbobrowicz added a commit to rbobrowicz/aws-cdk that referenced this issue Jun 1, 2020
Gives users the option to choose between detailed and basic monitoring.
Defaults to detailed when not specified, maintaining current behavior.

fixes aws#8212
rbobrowicz added a commit to rbobrowicz/aws-cdk that referenced this issue Jun 1, 2020
Gives users the option to choose between detailed and basic monitoring.
Defaults to detailed when not specified, maintaining current behavior.

fixes aws#8212
rbobrowicz added a commit to rbobrowicz/aws-cdk that referenced this issue Jun 2, 2020
Gives users the option to choose between detailed and basic monitoring.
Defaults to detailed when not specified, maintaining current behavior.

fixes aws#8212
@spg
Copy link
Contributor

spg commented Jun 10, 2020

Current workaround:

const autoScalingGroup = new autoscaling.AutoScalingGroup(this, "Asg", {
    ...
});

const launchConfig = autoScalingGroup.node.findChild(
  "LaunchConfig"
) as autoscaling.CfnLaunchConfiguration;
launchConfig.instanceMonitoring = false;

rbobrowicz added a commit to rbobrowicz/aws-cdk that referenced this issue Jun 10, 2020
Gives users the option to choose between detailed and basic monitoring.
Defaults to detailed when not specified, maintaining current behavior.

fixes aws#8212
rbobrowicz added a commit to rbobrowicz/aws-cdk that referenced this issue Jun 10, 2020
Gives users the option to choose between detailed and basic monitoring.
Defaults to detailed when not specified, maintaining current behavior.

fixes aws#8212
@mergify mergify bot closed this as completed in #8213 Jun 11, 2020
mergify bot pushed a commit that referenced this issue Jun 11, 2020
Gives users the option to choose between detailed and basic monitoring.
Defaults to detailed when not specified, maintaining current behavior.

Fixes #8212 
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants