-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline config not showing up on synth output #6923
Comments
Yeah looks like we are not forwarding pipelineConfig from the L2 to CfnResolver. imo, we should remove some of the unnecessary information from the |
@MrArnoldPalmer what do you think is a reasonable eta on this? no pipeline resolvers means using CDK for Appsync is only a partial solution. |
@iamtheworstdev a PR has been submitted but stalled out for now. @Thomazella do you plan on continuing or should we take this over to close it out? |
Please take it over. Seems pretty simple but I'm terribly busy lately 🙏 |
@iamtheworstdev feel free to jump in if you want to add some tests and try to get this resolved. Otherwise I'll add it to my list but its a long one at the moment 😉 |
@MrArnoldPalmer assume I'm not, because it's not just a clever moniker but you probably don't want me writing the code. but I think my work around for avoid pipelines just reached the end of its useful life so I may. I'll comment back in here if I start any work. |
Just hit this issue myself today. Took me a while to realise that the pipeline config just wasn't being populated 😅 Any chance this issue could get some love. We're realising more and more how powerful AppSync is and these last few bits polish in CDK will really improve the dev experience. |
Any update on the same ? seems like a bad bug, would be great if you guys can fix it. I am currently blocked on the same |
Hi @alextriaca @Vengadanathan I'll start working on this today, my goal is to complete it and merge by Thursday. For future reference, please add a 👍 to the issues that you are stuck on that way they can get sorted to the top :) |
I believe the work around to this pipeline would be to create multiple resolvers as follows.
specifically making two different data sources and make separate resolvers for each of them. |
Okay I think I found the root of the confusion. The See documentation on See documentation on See documentation on If you want to use That being said, CDK doesn't have implementation for AppSync Function so I will close this issue and opening #9092 for a feature request for AppSync function creation. |
**[ISSUE]** `pipelineConfig` was be labeled as `undefined` while using the `Resolver` class instead of `createResolver`. Also, no way to set `kind` parameter for resolvers, so implemented that as well. **[APPROACH]** Created a property that takes `pipelineConfig` for `AppSync` functions. **[NOTE]** `pipelineConfig` takes a string array for the name of `AppSync Functions` not `Lambda Functions` Fixes #6923 BREAKING CHANGE: `pipelineConfig` is now an array of `string` instead of `CfnResolver.PipelineConfigProperty` for usability. - **appsync**: `pipelineConfig` parameter takes in `string []` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
**[ISSUE]** `pipelineConfig` was be labeled as `undefined` while using the `Resolver` class instead of `createResolver`. Also, no way to set `kind` parameter for resolvers, so implemented that as well. **[APPROACH]** Created a property that takes `pipelineConfig` for `AppSync` functions. **[NOTE]** `pipelineConfig` takes a string array for the name of `AppSync Functions` not `Lambda Functions` Fixes aws#6923 BREAKING CHANGE: `pipelineConfig` is now an array of `string` instead of `CfnResolver.PipelineConfigProperty` for usability. - **appsync**: `pipelineConfig` parameter takes in `string []` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Reproduction Steps
Error Log
see screnshot
Environment
Other
I'm passing a valid, as per cdk types,
pipelineConfig
but it shows as undefined in mycdk synth
output, causing deploy to fail even though my cdk code looks correctThis is 🐛 Bug Report
The text was updated successfully, but these errors were encountered: