Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GlobalAccelerator construct #5527

Closed
2 tasks
hleb-albau opened this issue Dec 23, 2019 · 9 comments · Fixed by #8221
Closed
2 tasks

Add GlobalAccelerator construct #5527

hleb-albau opened this issue Dec 23, 2019 · 9 comments · Fixed by #8221
Assignees
@rix0rrr
Labels
@aws-cdk/aws-globalaccelerator Related to AWS Global Accelerator effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@hleb-albau
Copy link

There is GlobalAccelerator service provided by aws. It would be nice, if it can be deployable from cdk.

Use Case

Use GlobalAccelerator in cdk stacks for multi-region services.

Proposed Solution

There are a few implementation of CF custom resource, that support GlobalAccelerator deploy, may be we can reuse one of them as a starting point.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@hleb-albau hleb-albau added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 23, 2019
@netroy
Copy link
Contributor

netroy commented Dec 23, 2019

This is currently not supported by Cloudformation.
Progress can be tracked here

@hleb-albau
Copy link
Author

This is currently not supported by Cloudformation.
Progress can be tracked here

Yeah, dynamo global tables too, but they implemented via custom resources. If you know internal status of CF impl for Global Accelerator, maybe you can suggest to wait a bit.... if no, we can try to impl it using https://github.com/binxio/cfn-global-accelerator-provider or something like that.

@netroy
Copy link
Contributor

netroy commented Dec 23, 2019

Global tables is already implemented in CDK as a custom resource here.
Maybe you can create something similar for GlobalAccelerator

@hleb-albau
Copy link
Author

Global tables is already implemented in CDK as a custom resource here.
Maybe you can create something similar for GlobalAccelerator

yeah, that's a point. let's wait some aws contact, maybe they will shine on CF Global Accelerator impl date.

@ccfife ccfife added needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. and removed needs-triage This issue or PR still needs to be triaged. labels May 6, 2020
@ccfife
Copy link
Contributor

ccfife commented May 6, 2020

Creating a CDK Construct Library for GlobalAcclerator via a custom resource is not prioritized on the CDK roadmap at this time. Please +1 the issue on the CloudFormation roadmap so that it's implemented as a proper resource type, and then automatically added to the AWS Construct Library when the CDK build processes the CFN resource spec that includes this resource.

@RomainMuller
Copy link
Contributor

According to this news, GlobalAccelerator is now available in CloudFormation. It has however not yet surfaced in the CloudFormation Resource Specification (only a matter of time!).

Once the resource is advertised in the specification, CDK will pick this up automatically and include it in the next release or so.

@hleb-albau
Copy link
Author

Good news everyone!

@pahud
Copy link
Contributor

pahud commented May 20, 2020

I have a working sample here
https://twitter.com/pahudnet/status/1262939019886817281

Will be happy to create L2 for it when L1 has been checked in.

@pahud pahud mentioned this issue May 27, 2020
Merged
@pahud
Copy link
Contributor

pahud commented May 27, 2020

I'm working on it now #8221

@SomayaB SomayaB added in-progress This issue is being actively worked on. @aws-cdk/aws-globalaccelerator Related to AWS Global Accelerator and removed needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. labels May 27, 2020
@SomayaB SomayaB assigned rix0rrr and unassigned ccfife May 27, 2020
@rix0rrr rix0rrr added the effort/large Large work item – several weeks of effort label May 28, 2020
@mergify mergify bot closed this as completed in #8221 Jun 16, 2020
mergify bot pushed a commit that referenced this issue Jun 16, 2020
@pahud
feat(globalaccelerator): support Accelerator, Listener and EndpointGr…
e4e8270 
…oup (#8221)

feat(globalaccelerator): support Accelerator, Listener and EndpointGroup

- Add `Accelerator`, `Listener` and `EndpointGroup` resources
- support `addEndpoint`, `addLoadBalancer`, `addElasticIpAddress` and `addEc2Instance` to add any supported endpoint into the `EndpointGroup`

Closes #5527 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-globalaccelerator Related to AWS Global Accelerator effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(globalaccelerator): support Accelerator, Listener and EndpointGroup
7 participants
@netroy @pahud @RomainMuller @rix0rrr @hleb-albau @SomayaB @ccfife